https://bugzilla.redhat.com/show_bug.cgi?id=1482867
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
$ rpm -qp --requires perl-JSON-Parse-0.49-1.fc28.x86_64.rpm | sort | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.14)(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.3.4)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.26()(64bit)
1 perl(Carp)
1 perl(Exporter)
1 perl(Getopt::Long)
1 perl(JSON::Parse)
1 perl(lib)
1 perl(:MODULE_COMPAT_5.26.0)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
1 /usr/bin/perl
Binary requires are Ok.
$ rpm -qp --provides perl-JSON-Parse-0.49-1.fc28.x86_64.rpm | sort | uniq -c
1 perl(JSON::Parse) = 0.49
1 perl-JSON-Parse = 0.49-1.fc28
1 perl-JSON-Parse(x86-64) = 0.49-1.fc28
1 perl(JSON::Tokenize) = 0.49
Binary provides are Ok.
$ rpmlint ./perl-JSON-Parse.spec ./perl-JSON-Parse-0.49-1.fc28.*
perl-JSON-Parse.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-JSON-Parse.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-JSON-Parse.x86_64: W: no-manual-page-for-binary validjson
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
Rpmlint is ok
$ rpm -qplv perl-JSON-Parse-0.49-1.fc28.x86_64.rpm
-rwxr-xr-x 1 root root 1121 Aug 18 12:33
/usr/bin/validjson
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/lib/.build-id
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/lib/.build-id/8c
lrwxrwxrwx 1 root root 64 Aug 18 12:33
/usr/lib/.build-id/8c/049a7e2ba55b5d11475fdc41307f5b80a53869 ->
../../../../usr/lib64/perl5/vendor_perl/auto/JSON/Parse/Parse.so
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/lib64/perl5/vendor_perl/JSON
-rw-r--r-- 1 root root 1850 Nov 26 2016
/usr/lib64/perl5/vendor_perl/JSON/Parse.pm
-rw-r--r-- 1 root root 54160 Nov 26 2016
/usr/lib64/perl5/vendor_perl/JSON/Parse.pod
-rw-r--r-- 1 root root 369 Nov 26 2016
/usr/lib64/perl5/vendor_perl/JSON/Tokenize.pm
-rw-r--r-- 1 root root 3496 Nov 26 2016
/usr/lib64/perl5/vendor_perl/JSON/Tokenize.pod
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/lib64/perl5/vendor_perl/auto/JSON
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/lib64/perl5/vendor_perl/auto/JSON/Parse
-rwxr-xr-x 1 root root 87832 Aug 18 12:33
/usr/lib64/perl5/vendor_perl/auto/JSON/Parse/Parse.so
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse
-rw-r--r-- 1 root root 3955 Nov 26 2016
/usr/share/doc/perl-JSON-Parse/Changes
-rw-r--r-- 1 root root 3448 Nov 26 2016
/usr/share/doc/perl-JSON-Parse/README
drwxr-xr-x 2 root root 0 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples
-rw-r--r-- 1 root root 133 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/array.pl
-rw-r--r-- 1 root root 231 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/assert.pl
-rw-r--r-- 1 root root 363 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/bad-utf8.pl
-rw-r--r-- 1 root root 376 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/bad-utf8.txt
-rw-r--r-- 1 root root 285 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/chr.pl
-rw-r--r-- 1 root root 221 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/collide.pl
-rw-r--r-- 1 root root 229 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/ebi.pl
-rw-r--r-- 1 root root 814 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/first-bit.pl
-rw-r--r-- 1 root root 132 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/hash.pl
-rw-r--r-- 1 root root 1055 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/json-tiny-round-trip-demo.pl
-rw-r--r-- 1 root root 313 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/kani.pl
-rw-r--r-- 1 root root 217 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/key-collision.pl
-rw-r--r-- 1 root root 198 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/long-number.pl
-rw-r--r-- 1 root root 222 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/sasori.pl
-rw-r--r-- 1 root root 186 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/synopsis.pl
-rwxr-xr-x 1 root root 627 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/tokenize-synopsis.pl
-rw-r--r-- 1 root root 221 Aug 18 12:33
/usr/share/doc/perl-JSON-Parse/examples/true-subs.pl
-rw-r--r-- 1 root root 18966 Aug 18 12:33
/usr/share/man/man3/JSON::Parse.3pm.gz
-rw-r--r-- 1 root root 2494 Aug 18 12:33
/usr/share/man/man3/JSON::Tokenize.3pm.gz
FIX: Please remove execute permission from examples/tokenize-synopsis.pl,
it is part of documentation.
BuildRequires are almost ok.
FIX: Please add perl-devel and gcc, because it is XS package
Please correct all 'FIX' issues.
Otherwise, the package looks good.
Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component