Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
Summary: Merge Review: memtest86+ Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: wtogami@redhat.com
Fedora Merge Review: memtest86+
http://cvs.fedora.redhat.com/viewcvs/devel/memtest86+/ Initial Owner: wtogami@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |ruben@rubenkerkhof.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@rubenkerkhof.com |wtogami@redhat.com CC| |ruben@rubenkerkhof.com Flag|fedora-review? |fedora-review-
------- Additional Comments From ruben@rubenkerkhof.com 2007-02-03 16:22 EST ------- Hi Warren,
Review for release 4.1: * RPM name is OK * Source memtest86+-1.65.tar.gz is the same as upstream * Builds fine in mock * File list looks OK
Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines)
Notes: * Please use {?dist} in Release tag * Is the Obsoletes: memtest86 still necessary?
Rpmlint is not silent:
Source RPM: W: memtest86+ strange-permission new-memtest-pkg 0775 W: memtest86+ strange-permission memtest-setup 0775 W: memtest86+ unversioned-explicit-obsoletes memtest86 W: memtest86+ macro-in-%changelog version
rpmlint of memtest86+: E: memtest86+ obsolete-not-provided memtest86 E: memtest86+ no-binary W: memtest86+ wrong-file-end-of-line-encoding /usr/share/doc/memtest86+-1.65/README
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wtogami@redhat.com |ruben@rubenkerkhof.com Flag|fedora-review- |fedora-review?
------- Additional Comments From wtogami@redhat.com 2007-02-03 17:44 EST -------
Needs work:
- BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot)
OK
- Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake)
OK, comment indicates that it isn't necessary.
- Spec file: some paths are not replaced with RPM macros
(wiki: QAChecklist item 7)
Nothing remaining has a standardized macro available.
- The package should contain the text of the license
(wiki: Packaging/ReviewGuidelines)
- MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
(does not apply)
Notes:
- Please use {?dist} in Release tag
DONE
- Is the Obsoletes: memtest86 still necessary?
Not really, removed
rpmlint of memtest86+: E: memtest86+ no-binary
rpmlint is just confused by this strange package.
W: memtest86+ wrong-file-end-of-line-encoding
/usr/share/doc/memtest86+-1.65/README What?!
(Assigning back to reviewer)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ruben@rubenkerkhof.com |wtogami@redhat.com Flag|fedora-review? |fedora-review+
------- Additional Comments From ruben@rubenkerkhof.com 2007-02-03 18:03 EST -------
Nothing remaining has a standardized macro available.
Only the /usr/include in BuildRequires
/usr/share/doc/memtest86+-1.65/README What?!
[ruben@odin memtest86+-1.65]$ file README README: ASCII English text, with CRLF line terminators
[ruben@odin memtest86+-1.65]$ hexdump -C README | tail -3 000089b0 6d 74 65 73 74 38 36 2b 20 76 31 2e 31 31 29 2e |mtest86+ v1.11).| 000089c0 0d 0a |..| 000089c2
0d 0a, that's CRLF on the last line. Nevermind, this is nitpicking
This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
------- Additional Comments From wtogami@redhat.com 2007-02-03 21:53 EST ------- Ah thanks. I fixed the includedir macro.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
david.r.bentley@btinternet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |david.r.bentley@btinternet.c | |om
------- Additional Comments From david.r.bentley@btinternet.com 2007-03-31 10:30 EST ------- I assume the reason for not having it available at boot on F7 test 3 is that this package is still undergoing review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
------- Additional Comments From wtogami@redhat.com 2007-04-01 20:53 EST ------- No. Merge Review is only a qualify improvement sweep. You can install memtest86+ after install, or you can use it from the initial menu when booting the installer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
------- Additional Comments From david.r.bentley@btinternet.com 2007-04-03 15:38 EST ------- In F7 test 3 you need to press ESC then ENTER to get to the boot promt (no cursor)then either F1 - F5 to get the various text help screens and on typing the usual memtest86 you get could not find kernel image: memtest86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: memtest86+
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226135
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org