https://bugzilla.redhat.com/show_bug.cgi?id=1909767
--- Comment #4 from Eduardo Lima (Etrunko) <elima(a)redhat.com> ---
(In reply to Christophe de Dinechin from comment #1)
===== MUST items =====
Generic:
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License
2.0",
"[generated file]", "GNU General Public License, Version 2",
"*No
copyright* [generated file]", "Expat License", "*No copyright*
Expat
License", "Apache License 2.0", "BSD 3-clause "New" or
"Revised"
License", "ISC License", "BSD 2-clause "Simplified"
License", "*No
copyright* Mozilla Public License 2.0", "*No copyright* GNU Lesser
General Public License, Version 3". 2683 files have unknown license.
Detailed output of licensecheck in /home/ddd/1909767-kata-
containers/licensecheck.txt
c3d: Did not have time to check all the generated files, because
c3d: they use @generated, which is not known to fedora-review
Out of curiosity, I went through the list of vendor code (patch) and checked
for the licencing for each one of them. All of the projects have a permissive
license, in the kinds of MIT, BSD, Apache 2.0.
[S]: If the package is a rename of another package, proper Obsoletes
and
Provides are present.
c3d: Do we want to maintain two parallel packages for now?
c3d: There is no Obsolete: or Provides: for kata-runtime, for example
Fabiano provided the reasoning in comment #3.
[S]: Requires correct, justified where necessary.
c3d: Used to build the images - Possibly add a comment?
Fixed.
[S]: Only use %_sourcedir in very specific situations.
Note: %_sourcedir/$RPM_SOURCE_DIR is used.
c3d: Add comment to explain why you need it?
Fixed.
[?]: Useful -debuginfo package or justification otherwise.
c3d: The macros look good to me, but I did not try the package
Enabling debug build returns an error which I am not sure how to fix at the
moment.
RPM build errors:
Missing build-id in
/home/elima/rpmbuild/BUILDROOT/kata-containers-2.0.0-1.fc33.x86_64/usr/libexec/kata-containers/kata-netmon
Generating build-id links failed
This error turns into a warning only when debuginfo is disabled.
warning: Missing build-id in
/home/elima/rpmbuild/BUILDROOT/kata-containers-2.0.0-1.fc33.x86_64/usr/libexec/kata-containers/kata-netmon
[S]: Package is not known to require an ExcludeArch tag.
c3d: The package does have ExcludeArch, for good reasons I believe
c3d: Add comment on the reasons (do we have a BZ or a JIRA?)
Fixed.
===== SHOULD items =====
Generic:
[S]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
c3d: Justified in patch text
c3d: Issue upstream exists and is documented in patch (#1203)
c3d: Explain why we need to vendor Rust code that way but not Go?
Not required.
[S]: %check is present and all tests pass.
c3d: No %check at the moment, running it locally is difficult
c3d: Consider adding a "make check LIBC=gnu" step?
Make check fails with upstream code, it can be enabled whenever the check
passes.
[S]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define have_go_rpm_macros 1,
%define have_go_rpm_macros 0, %define qemu qemu-kvm, %define qemupath
%{_bindir}/%{qemu}, %define qemupath %{_libexecdir}/%{qemu}, %define
machinetype "virt", %define machinetype "pseries", %define
machinetype
"s390-ccw-virtio", %define machinetype "q35"
c3d: Probably worth changing these to silence the warning?
Fixed.
===== EXTRA items =====
Generic:
Rpmlint
-------
Checking: kata-containers-2.0.0-1.fc31.x86_64.rpm
kata-containers-2.0.0-1.fc31.src.rpm
kata-containers.x86_64: W: summary-ended-with-dot C Kata Containers version
2.x repository.
[S] c3d: Please fix, easy to do.
Fixed.
kata-containers.x86_64: W: unstripped-binary-or-object
/usr/bin/containerd-shim-kata-v2
kata-containers.x86_64: W: unstripped-binary-or-object /usr/bin/kata-monitor
kata-containers.x86_64: W: unstripped-binary-or-object /usr/bin/kata-runtime
kata-containers.x86_64: W: unstripped-binary-or-object
/usr/libexec/kata-containers/agent/usr/bin/kata-agent
kata-containers.x86_64: W: unstripped-binary-or-object
/usr/libexec/kata-containers/kata-netmon
kata-containers.x86_64: W: unstripped-binary-or-object
/usr/libexec/kata-containers/osbuilder/nsdax
[S] c3d: I don't remember seeing that for the 1.x packages. Please
investigate why.
These warnings happen because debuginfo is not enabled.
kata-containers.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/kata-containers/osbuilder/image-builder/nsdax.gpl.c
[M] c3d: Justified for the use case.
Removed from the installed package.
kata-containers.x86_64: E: non-standard-executable-perm
/usr/libexec/kata-containers/osbuilder/kata-osbuilder.sh 775
[S] c3d: Should probably be addressed
Fixed.
kata-containers.x86_64: E: non-executable-script
/usr/share/bash-completion/completions/kata-runtime 644 /bin/bash
[S] c3d: I think it's a missing shebang, see the following lines in
kata-runtime.spec:
# keep: Minor local patches
Patch0001: 0001-Remove-shebang-in-non-executable-completion-script.patch
Fixed.
kata-containers.x86_64: W: no-manual-page-for-binary
containerd-shim-kata-v2
kata-containers.x86_64: W: no-manual-page-for-binary kata-collect-data.sh
kata-containers.x86_64: W: no-manual-page-for-binary kata-monitor
kata-containers.x86_64: W: no-manual-page-for-binary kata-runtime
[S] c3d: Please consider opening an issue upstream
OK.
kata-containers.x86_64: W: empty-%postun
[M] c3d: Why is this flagged? There is a %systemd_postun there.
kata-containers.src: W: summary-ended-with-dot C Kata Containers
version 2.x
repository.
kata-containers.src: W: strange-permission kata-osbuilder.sh 775
kata-containers.src:92: W: macro-in-comment %check
[S] Please remove the %chek in the comment (all the more since we have no
%check yet ;-)
Fixed.
kata-containers.src:281: E: use-of-RPM_SOURCE_DIR
[M] c3d: Same as in kata-runtime. If you have an idea on how to fix it?
2 packages and 0 specfiles checked; 3 errors, 16 warnings.
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component