https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Bug ID: 2294109 Summary: Review Request: golang-github-nvidia-nvlib - A collection of useful Go libraries for use with NVIDIA GPU management tools Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: debarshir@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38...
Description:
A collection of useful Go libraries for use with NVIDIA GPU management tools.
This package contains the source code needed for building packages that reference the following Go import paths: – github.com/NVIDIA/go-nvlib
Fedora Account System Username: rishi
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #2 from Debarshi Ray debarshir@redhat.com --- Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38...
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2293636
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2293636 [Bug 2293636] Review Request: golang-github-nvidia-nvml - Go Bindings for the NVIDIA Management Library (NVML)
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #3 from Debarshi Ray debarshir@redhat.com --- The latest release of the github.com/NVIDIA/go-nvlib module is v0.6.0. However, anything more recent than v0.2.0 is not compatible with the latest v1.15.0 release of github.com/NVIDIA/nvidia-container-toolkit. That's why I chose to package only v0.2.0 for the time being. We can update once there's a newer release of the github.com/NVIDIA/nvidia-container-toolkit module.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #4 from Debarshi Ray debarshir@redhat.com --- (In reply to Debarshi Ray from comment #2)
Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38. noarch.rpm
Damn, that's not the SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #5 from Debarshi Ray debarshir@redhat.com --- Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-0.2.0-1.fc38.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7663311 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #7 from Debarshi Ray debarshir@redhat.com --- (In reply to Fedora Review Service from comment #6)
Copr build: https://copr.fedorainfracloud.org/coprs/build/7663311 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- review-2294109-golang-github-nvidia-nvlib/fedora-rawhide-x86_64/07663311- golang-github-nvidia-nvlib/builder-live.log.gz
Please make sure the package builds successfully at least for Fedora Rawhide.
The build failed with: No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/dl) No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/nvml)
That's going to be addressed by the package review of golang-github-nvidia-nvml in bug 2293636
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #8 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
install --mode 0644 --preserve-timestamps --verbose \ pkg/pciids/default_pci.ids \ %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/ (...) %{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
You can replace this with after `%global godoc`:
%global gosupfiles pkg/pciids/default_pci.ids
Check golang-github-projectdiscovery-cdncheck.spec or golang-x-crypto.spec as example.
package-review@lists.fedoraproject.org