https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Bug ID: 1393796 Summary: Review Request: golang-github-go-errors-error - Package errors provides errors that have stack-traces Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: giallu@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec SRPM URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.1.gita418... Description:
Package errors adds stacktrace support to errors in go.
This is particularly useful when you want to understand the state of execution when an error was returned unexpectedly.
It provides the type *Error which implements the standard golang error interface, so you can use this library interchangably with code that is expecting a normal error return.
Fedora Account System Username: giallu
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1394193
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1394193 [Bug 1394193] Review Request: arduino-builder - A command line tool for compiling Arduino sketches
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Dennis Chen barracks510@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |barracks510@gmail.com Assignee|nobody@fedoraproject.org |barracks510@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #1 from Dennis Chen barracks510@gmail.com --- I don't think we'll be targeting EPEL6, at least not with the arduino releases, could you simplify the SPEC to remove of all the unnecessary macros?
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #2 from Gianluca Sforna giallu@gmail.com --- Just for clarification it seems we haven't approved official packaging guidelines, so I relied on the gofed tool and https://fedoraproject.org/wiki/PackagingDrafts/Go to build the spec file. That's where all those macro and stuff comes from.
So, I cleaned it up a little, have a look at: Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec SRPM URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.2.gita418...
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Dennis Chen barracks510@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #3 from Dennis Chen barracks510@gmail.com --- Ok. We can get rid of the ExclusiveArch, and then remove some unnecessary lines/comments:
%if 0%{?with_check} && ! 0%{?with_bundled} %endif
%if 0%{?with_check} #Here comes all BuildRequires: PACKAGE the unit tests #in %%check section need for running %endif
etc... And then I think we're good to go.
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #4 from Gianluca Sforna giallu@gmail.com --- (In reply to Dennis Chen from comment #3)
Ok. We can get rid of the ExclusiveArch,
the example mentions el6, but I am not sure it is limited to that. Without that macro, we need keep track manually of which archs golang is available.
I think it would be wiser to keep it, but if you insist I will remove it.
and then remove some unnecessary lines/comments:
%if 0%{?with_check} && ! 0%{?with_bundled} %endif
Done
%if 0%{?with_check} #Here comes all BuildRequires: PACKAGE the unit tests #in %%check section need for running %endif
Done
etc... And then I think we're good to go.
and done
See: Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec SRPM URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.3.gita418...
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #5 from Gianluca Sforna giallu@gmail.com --- Ping?
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Dennis Chen barracks510@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Dennis Chen barracks510@gmail.com --- (In reply to Gianluca Sforna from comment #5)
Ping?
Sorry, Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-errors-e...
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-go-errors-err |golang-github-go-errors-err |or - Package errors |ors - Package errors |provides errors that have |provides errors that have |stack-traces |stack-traces
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-errors-e...
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6e81af815
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-77b140109e
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6e81af815
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-77b140109e
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-27 00:19:08
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1393796
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org