Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Bug ID: 890806 Summary: Review Request: perl-XML-SAX-ExpatXS - Perl SAX 2 XS extension to Expat parser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: miro@hroncok.cz
Spec URL: https://raw.github.com/hroncok/SPECS/master/perl-XML-SAX-ExpatXS.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-XML-SAX-ExpatXS-1.33-3.fc17....
Description: XML::SAX::ExpatXS is a direct XS extension to Expat XML parser. It implements Perl SAX 2.1 interface. See http://perl-xml.sourceforge.net/perl- sax/ for Perl SAX API description. Any deviations from the Perl SAX 2.1 specification are considered as bugs.
Fedora Account System Username: churchyard
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW), | |244485 CC| |cweyl@alumni.drew.edu
--- Comment #1 from Miro Hrončok miro@hroncok.cz --- *** Bug 244484 has been marked as a duplicate of this bug. ***
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org Assignee|nobody@fedoraproject.org |misc@zarb.org Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #2 from Michael Scherer misc@zarb.org --- The package is good, there is just one single issue , you should ask upstream to ship the license, but that's not blocking. So the package is approved.
Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Perl". 2 files have unknown license. Detailed output of licensecheck in /home/misc/checkout/git/FedoraReview/890806 -perl-XML-SAX-ExpatXS/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages.
Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned.
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: perl-XML-SAX-ExpatXS-1.33-3.fc19.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint perl-XML-SAX-ExpatXS 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- perl-XML-SAX-ExpatXS (rpmlib, GLIBC filtered): libc.so.6()(64bit) libexpat.so.1()(64bit) perl perl(:MODULE_COMPAT_5.16.2) perl(Carp) perl(DynaLoader) perl(IO::File) perl(XML::SAX) perl(XML::SAX::Base) perl(XML::SAX::ExpatXS) perl(XML::SAX::ExpatXS::Encoding) perl(XML::SAX::ExpatXS::Preload) perl(overload) perl(strict) perl(vars) rtld(GNU_HASH)
Provides -------- perl-XML-SAX-ExpatXS: perl(XML::SAX::ExpatXS) perl(XML::SAX::ExpatXS::ContentModel) perl(XML::SAX::ExpatXS::Encinfo) perl(XML::SAX::ExpatXS::Encoding) perl(XML::SAX::ExpatXS::Preload) perl-XML-SAX-ExpatXS perl-XML-SAX-ExpatXS(x86-64)
Unversioned so-files -------------------- perl-XML-SAX-ExpatXS: /usr/lib64/perl5/vendor_perl/auto/XML/SAX/ExpatXS/ExpatXS.so
MD5-sum check ------------- http://www.cpan.org/authors/id/P/PC/PCIMPRICH/XML-SAX-ExpatXS-1.33.tar.gz : CHECKSUM(SHA256) this package : 1e3db191853d235c42c7d2a5dc2ea055158ff29c7d54c5c673d271cdbd43bc6a CHECKSUM(SHA256) upstream package : 1e3db191853d235c42c7d2a5dc2ea055158ff29c7d54c5c673d271cdbd43bc6a
Generated by fedora-review 0.2.0 (Unknown) last change: Unknown Buildroot used: fedora-rawhide-x86_64 Command line :./try-fedora-review -b 890806
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Miro Hrončok miro@hroncok.cz --- New Package SCM Request ======================= Package Name: perl-XML-SAX-ExpatXS Short Description: Perl SAX 2 XS extension to Expat parser Owners: churchyard Branches: f17 f18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #4 from Miro Hrončok miro@hroncok.cz --- Thanks for the review. I've asked upstream for the LICENSE file.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |890839
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #5 from Kevin Fenzi kevin@scrye.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-XML-SAX-ExpatXS-1.33-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-XML-SAX-ExpatXS-1.33-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #8 from Ville Skyttä ville.skytta@iki.fi --- Created attachment 670690 --> https://bugzilla.redhat.com/attachment.cgi?id=670690&action=edit Register/unregister XML::SAX parser properly
Just like in bug 244484 comment 1, XML::SAX parser registration/unregistration is missing; see perl-XML-SAX and perl-XML-LibXML for examples.
Fix attached, along with a fix to *not* alter ParserDetails.ini (i.e. do the XML::SAX registration) in the build root - doing that there makes no sense, it needs to be done at install time.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #9 from Miro Hrončok miro@hroncok.cz --- Thanks, I revoked the updates.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-XML-SAX-ExpatXS-1.33-4.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-XML-SAX-ExpatXS-1.33-4.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-4.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@redhat.com Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #13 from Petr Šabata psabata@redhat.com --- Package Change Request ====================== Package Name: perl-XML-SAX-ExpatXS Branches: f17 f18 Owners: InitialCC: perl-sig
Please add perl-sig user with watch* permissions only to all Fedora branches.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Complete.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-11 18:45:01
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-4.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890806
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-XML-SAX-ExpatXS-1.33-4.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org