Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libwiiuse - library to use wiiremotes via bluetooth
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Summary: Review Request: libwiiuse - library to use wiiremotes via bluetooth Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ssorce@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://simo.fedorapeople.org/libwiiuse/wiiuse.spec SRPM URL: http://simo.fedorapeople.org/libwiiuse/libwiiuse-0.12-0.fc11.src.rpm Description: A library that implements access to wiiremote controllers via bluetooth.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Kris Buytaert kris.buytaert@inuits.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kris.buytaert@inuits.be
--- Comment #1 from Kris Buytaert kris.buytaert@inuits.be 2010-01-06 17:16:09 EDT --- First quick look :
$ rpmlint libwiiuse-0.12-0.fc11.src.rpm libwiiuse.src: E: invalid-spec-name 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpmlint wiiuse.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Package fails against :
MUST: The spec file name must match the base package %{name},
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #2 from Simo Sorce ssorce@redhat.com 2010-01-06 17:42:48 EDT --- oops sorry, I forgot to rename it after I decided to rename the package from wiiuse to libwiiuse.
I have uploaded a new src.rpm and spec file with the right name.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2010-11-16 15:05:34 EST --- Did anything ever happen with this package? I see plenty of commentary but no updated srpm.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #8 from Simo Sorce ssorce@redhat.com 2010-11-16 15:34:59 EST --- I've got distracted and haven't updated it. Will see if I can find out some time in the week end.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2010-11-16 16:09:29 EST --- Cool, thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #10 from Simo Sorce simo@fedoraproject.org 2010-11-20 18:32:11 EST --- Ok I have uploaded new spec file and src.rpm to http://simo.fedorapeople.org/libwiiuse/
This should solve the problems reported earlier. I still have this though:
libwiiuse-debuginfo.i686: E: empty-debuginfo-package
Not sure how to solve that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #11 from Jason Tibbitts tibbs@math.uh.edu 2010-11-22 13:18:21 EST --- The "empty-debuginfo-package" thing is probably a symptom of the package not building with the proper compiler flags. Either the flags need to be passed to make or the Makefile needs patching.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu 2010-11-25 13:27:59 EST --- I did take a look at the Makefile and it looks that even though you can pass CFLAGS, it will only use it for the final link and not building any of the source files. You'll have to sed or patch out the CFLAGS manipulation in each of the Makefiles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #13 from Simo Sorce simo@fedoraproject.org 2010-11-25 15:19:09 EST --- Ok I added a patch (wiiuse_cflags.patch) so that the makefiles do not reset cflags but add to environment defined ones.
Setting CFALGS=-g in the shell before running rpmbuild now generated non-empty debuginfo files. I guess this means it will properly pick up whatever CFLAGS are set in the koji environment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #14 from Jason Tibbitts tibbs@math.uh.edu 2010-11-26 09:38:40 EST --- Well, there is no default CFLAGS set in the koji environment. The only environment is what you specify in your spec file. Note that usually the %configure macro sets CFLAGS, which may be what you're used to, but of course this software doesn't use autoconf.
So, you probably need to stick CFLAGS='%optflags' on your make line.
If you post an updated package I'll take a look. All I see is the same release 0 package I already looked at. (Of course, your release should start at 1, and you should increment it whenever you update the package, even during review.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #15 from Simo Sorce simo@fedoraproject.org 2010-11-26 10:36:19 EST --- Ok now passing CFLAGS to make in %build and bumped up release number. Let me know if there is anything else to change.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #16 from Jason Tibbitts tibbs@math.uh.edu 2010-11-30 21:24:58 EST --- Could you elaborate on why you chose to rename from wiiuse to libwiiuse? The upstream project name seems to be wiiuse.
The summary of the main package could use some work. It doesn't say anything that the name of the package doesn't. I'd use something like "A library that connects with several Nintendo Wii remotes".
The license seems to be GPLv3+, not GPLv3. At least the source says so rather explicitly. Do you have some other source of information that indicates that the license is GPLv3 only? (Also, I asked the legal list about the LGPLv3/noncommercial thing and it appears that the best thing to do is ignore it completely.)
* source files match upstream. sha256sum: afc86b05ab201842c7f258e3d854171ede80167bd257272ae59d0cfbd342fb0d wiiuse_v0.12_src.tar.gz ? package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. X summary could use some work. * description is OK. * dist tag is present. X license field does not match the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: libwiiuse-0.12-1.fc15.x86_64.rpm libwiiuse.so.0()(64bit) libwiiuse = 0.12-1.fc15 libwiiuse(x86-64) = 0.12-1.fc15 = /sbin/ldconfig libbluetooth.so.3()(64bit)
libwiiuse-devel-0.12-1.fc15.x86_64.rpm libwiiuse-devel = 0.12-1.fc15 libwiiuse-devel(x86-64) = 0.12-1.fc15 = libwiiuse = 0.12-1.fc15 libwiiuse.so.0()(64bit)
libwiiuse-examples-0.12-1.fc15.x86_64.rpm libwiiuse-examples = 0.12-1.fc15 libwiiuse-examples(x86-64) = 0.12-1.fc15 = libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL-1.2.so.0()(64bit) libbluetooth.so.3()(64bit) libglut.so.3()(64bit) libwiiuse = 0.12-1.fc15 libwiiuse.so.0()(64bit)
* no bundled libraries. * shared libraries installed; ldconfig called properly. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets are OK (ldconfig). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no libtool .la files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #17 from Simo Sorce simo@fedoraproject.org 2010-12-12 15:38:48 EST --- (In reply to comment #16)
Could you elaborate on why you chose to rename from wiiuse to libwiiuse? The upstream project name seems to be wiiuse.
No special reason, I think debian packages maybe calling it so, and because it was just a library I prepended lib to the name.
I renamed the package, the spec, srpm, source and patches are now available here: http://simo.fedorapeople.org/wiiuse
The summary of the main package could use some work. It doesn't say anything that the name of the package doesn't. I'd use something like "A library that connects with several Nintendo Wii remotes".
Ok, I expanded the summary.
The license seems to be GPLv3+, not GPLv3. At least the source says so rather explicitly. Do you have some other source of information that indicates that the license is GPLv3 only? (Also, I asked the legal list about the LGPLv3/noncommercial thing and it appears that the best thing to do is ignore it completely.)
I probably just missed the (or later) clause the first time I read the license, then got busy evaluating whether the LGPLv3 part could be used or not in Fedora and came to the conclusion it was not free and therefore ignore it. (I am glad Legal came to the same conclusion :)
Fixed to GPLv3+
Hopefully I addressed all remaining concerns.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #18 from Jason Tibbitts tibbs@math.uh.edu 2010-12-15 15:44:21 EST --- I don't think it's a significant problem that you renamed it, although we do try to stick with the upstream names when it makes sense. Either way is fine with me; I was just asking for an explanation.
Unfortunately two problems were introduced. The big one is that the packages don't install; the -devel and -examples still depend on libwiiuse.
Also, the new summary grew a trailing dot and is also somewhat overlong:
wiiuse.x86_64: W: summary-ended-with-dot C The wiiuse library is used to access and control multiple Nintendo Wiimotes, the Wii remote controllers. wiiuse.x86_64: E: summary-too-long C The wiiuse library is used to access and control multiple Nintendo Wiimotes, the Wii remote controllers.
(not sure where rpmlint gets the 'C' from). Honestly you can probably drop the comma and everything after if you need to free space.
Sorry for all the back and forth.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #19 from Simo Sorce simo@fedoraproject.org 2011-01-16 10:49:22 EST --- Ok updated spec and srpm files in the usual place. I fixed the broken dependencies, and the summary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #20 from Jason Tibbitts tibbs@math.uh.edu 2011-01-19 22:21:12 EST --- OK, these install and the rpmlint complaints are no more. Looks good to me.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Simo Sorce ssorce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #21 from Simo Sorce simo@fedoraproject.org 2011-01-21 17:12:12 EST --- New Package SCM Request ======================= Package Name: wiiuse Short Description: The wiiuse library is used to access and control multiple Nintendo Wiimotes Owners: simo Branches: f15 master InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
--- Comment #22 from Jason Tibbitts tibbs@math.uh.edu 2011-01-21 17:14:08 EST --- It's too early to request f15 branches. Otherwise.... Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: libwiiuse - |Review Request: wiiuse - |library to use wiiremotes |library to use wiiremotes |via bluetooth |via bluetooth
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552113
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE Last Closed| |2011-04-08 11:46:41
--- Comment #23 from Jason Tibbitts tibbs@math.uh.edu 2011-04-08 11:46:41 EDT --- I see no reason to keep this ticket open as the package is in rawhide and F15.
package-review@lists.fedoraproject.org