https://bugzilla.redhat.com/show_bug.cgi?id=1237281
Bug ID: 1237281 Summary: Review Request: bashithacomplex-fonts - Sinhala fonts Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: danishka@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacompl...
SRPM URL: https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacompl...
Description: The bashithacomplex-fonts package contains fonts for the display of Sinhala.
Fedora Account System Username: snavin
Please note that, package license is mentioned in following page.
http://www.icta.lk/index.php?option=com_content&view=article&id=1497...
https://bugzilla.redhat.com/show_bug.cgi?id=1237281
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1237281
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review: + Package built fine for F23 x86_64
+ rpmlint on all generated rpms gave output bashithacomplex-fonts.noarch: W: spelling-error Summary(en_US) Bashitha -> Bashing bashithacomplex-fonts.noarch: W: no-documentation bashithacomplex-fonts.src: W: spelling-error Summary(en_US) Bashitha -> Bashing 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
+ Source verified with upstream as (sha256sum) Source in srpm:8460b239ee8fd0d92fcb2762b411d2560ba91b45958d49a24b1ee5a052d47008 Upstream source:8460b239ee8fd0d92fcb2762b411d2560ba91b45958d49a24b1ee5a052d47008
+ follows fonts packaging guidelines
Suggestions: 1) Correct the release tag as Release: 0.1.%{checkout}%{?dist}
2) You should also add metainfo file, see sample at http://pkgs.fedoraproject.org/cgit/lklug-fonts.git/tree/
and also do changes in spec file to install this bashithacomplex.metainfo.xml file
3) Note following lines are optional now in Fedora packages rm -fr %{buildroot} and %clean rm -fr %{buildroot}
4) Ask upstream to provide license somewhere on their website which we can download and add to this package. License is not clear just by downloading ttf file. Also, on upstream website they used word "BhashitaScreen" and it is not related to the font file we are packaging so not sure what license is for this BhashitaComplex font.
https://bugzilla.redhat.com/show_bug.cgi?id=1237281
Danishka Navin danishka@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |harshula@redhat.com
--- Comment #2 from Danishka Navin danishka@gmail.com --- Spec URL: https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacompl...
SRPM URL: https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacompl...
Fixed succession 1 and 2.
I already contacted upstream to provide license file, before start packaging. I hope they will provide it soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1237281
--- Comment #3 from Parag AN(पराग) panemade@gmail.com --- Any updates? Otherwise I will prefer to close this. Once any update is available either reopen this review or file a new package review.
Will close this in 2 weeks.
https://bugzilla.redhat.com/show_bug.cgi?id=1237281
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Flags|fedora-review? | Last Closed| |2017-12-22 02:50:21
package-review@lists.fedoraproject.org