https://bugzilla.redhat.com/show_bug.cgi?id=1769843
Michael Catanzaro <mcatanzaro(a)gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mcatanzaro(a)gnome.org
Assignee|nobody(a)fedoraproject.org |mcatanzaro(a)gnome.org
Flags| |needinfo?(bnocera(a)redhat.co
| |m)
--- Comment #1 from Michael Catanzaro <mcatanzaro(a)gnome.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- License file should be installed when any subpackage combination is
installed.
- Fully versioned dependency in subpackages if applicable.
The -docs subpackage should require the main package:
Requires: %{name} = %{version}-%{release}
- Should require systemd-rpm-macros rather than %{?systemd_requires}, per:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_de...
===== MUST items =====
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[-]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: %{_sysconfdir}/dbus-1/system.d/ is OK because systemd and D-Bus are
both required for low-memory-monitor to function
[x]: Package does not own files or directories owned by other packages.
Note: %{_datadir}/gtk-doc/html/ OK because gtk-doc is not required for
low-memory-monitor to function
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in low-memory-monitor
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in low-
memory-monitor-docs
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
But they are all strange false positives.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: low-memory-monitor-1.1-1.fc32.x86_64.rpm
low-memory-monitor-docs-1.1-1.fc32.noarch.rpm
low-memory-monitor-debuginfo-1.1-1.fc32.x86_64.rpm
low-memory-monitor-debugsource-1.1-1.fc32.x86_64.rpm
low-memory-monitor-1.1-1.fc32.src.rpm
low-memory-monitor.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.freedesktop.LowMemoryMonitor.conf
low-memory-monitor.x86_64: W: non-conffile-in-etc /etc/low-memory-monitor.conf
5 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (debuginfo)
-------------------
Checking: low-memory-monitor-debuginfo-1.1-1.fc32.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
low-memory-monitor-docs.noarch: W: invalid-url URL:
https://gitlab.freedesktop.org/hadess/low-memory-monitor <urlopen error [Errno
-2] Name or service not known>
low-memory-monitor-debuginfo.x86_64: W: invalid-url URL:
https://gitlab.freedesktop.org/hadess/low-memory-monitor <urlopen error [Errno
-2] Name or service not known>
low-memory-monitor-debugsource.x86_64: W: invalid-url URL:
https://gitlab.freedesktop.org/hadess/low-memory-monitor <urlopen error [Errno
-2] Name or service not known>
low-memory-monitor.x86_64: W: invalid-url URL:
https://gitlab.freedesktop.org/hadess/low-memory-monitor <urlopen error [Errno
-2] Name or service not known>
low-memory-monitor.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.freedesktop.LowMemoryMonitor.conf
low-memory-monitor.x86_64: W: non-conffile-in-etc /etc/low-memory-monitor.conf
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Source checksums
----------------
https://gitlab.freedesktop.org/hadess/low-memory-monitor/uploads/e9a3f55a...
:
CHECKSUM(SHA256) this package :
4eb644504a774adca7efa45dabd0c551dbeb4b9d1363fb1c68ddfa38875d43f3
CHECKSUM(SHA256) upstream package :
4eb644504a774adca7efa45dabd0c551dbeb4b9d1363fb1c68ddfa38875d43f3
Requires
--------
low-memory-monitor (rpmlib, GLIBC filtered):
/bin/sh
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
rtld(GNU_HASH)
systemd
low-memory-monitor-docs (rpmlib, GLIBC filtered):
low-memory-monitor-debuginfo (rpmlib, GLIBC filtered):
low-memory-monitor-debugsource (rpmlib, GLIBC filtered):
Provides
--------
low-memory-monitor:
low-memory-monitor
low-memory-monitor(x86-64)
low-memory-monitor-docs:
low-memory-monitor-docs
low-memory-monitor-debuginfo:
debuginfo(build-id)
low-memory-monitor-debuginfo
low-memory-monitor-debuginfo(x86-64)
low-memory-monitor-debugsource:
low-memory-monitor-debugsource
low-memory-monitor-debugsource(x86-64)
Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -b 1769843
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Python, fonts, R, PHP, SugarActivity, Haskell, Java, Ocaml,
Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component