Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=813197
Tomas Radej <tradej(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?
--- Comment #2 from Tomas Radej <tradej(a)redhat.com> 2012-04-24 08:05:05 EDT ---
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[!]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint python-django-devserver-0.3.1-1.fc18.src.rpm
python-django-devserver.src: W: spelling-error Summary(en_US) runserver -> run
server, run-server, server
python-django-devserver.src: W: spelling-error %description -l en_US runserver
-> run server, run-server, server
python-django-devserver.src: W: spelling-error %description -l en_US werkzeug
-> westernize
python-django-devserver.src: W: spelling-error %description -l en_US multi ->
mulch, mufti
python-django-devserver.src: W: file-size-mismatch LICENSE = 1522,
https://raw.github.com/dcramer/django-devserver/master/LICENSE = 1
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
rpmlint python-django-devserver-0.3.1-1.fc18.noarch.rpm
python-django-devserver.noarch: W: spelling-error Summary(en_US) runserver ->
run server, run-server, server
python-django-devserver.noarch: W: spelling-error %description -l en_US
runserver -> run server, run-server, server
python-django-devserver.noarch: W: spelling-error %description -l en_US
werkzeug -> westernize
python-django-devserver.noarch: W: spelling-error %description -l en_US multi
-> mulch, mufti
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/tradej/reviews/django-devserver-0.3.1.tar.gz :
MD5SUM this package : 3d1a3d6db0de3a2f44a4b6090cfa1f78
MD5SUM upstream package : 3d1a3d6db0de3a2f44a4b6090cfa1f78
/home/tradej/reviews/LICENSE :
MD5SUM this package : 3144dbfcdb5ce5fbb9c92f78655b86be
MD5SUM upstream package : 3144dbfcdb5ce5fbb9c92f78655b86be
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Issues:
[!]: MUST Package contains no bundled libraries.
>>> The *egg.info folder is not being erased in %prep
Notes:
[!]: MUST Rpmlint output is silent.
>>> Ignore that
rpmlint python-django-devserver-0.3.1-1.fc18.src.rpm
python-django-devserver.src: W: spelling-error Summary(en_US) runserver -> run
server, run-server, server
python-django-devserver.src: W: spelling-error %description -l en_US runserver
-> run server, run-server, server
python-django-devserver.src: W: spelling-error %description -l en_US werkzeug
-> westernize
python-django-devserver.src: W: spelling-error %description -l en_US multi ->
mulch, mufti
python-django-devserver.src: W: file-size-mismatch LICENSE = 1522,
https://raw.github.com/dcramer/django-devserver/master/LICENSE = 1
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
rpmlint python-django-devserver-0.3.1-1.fc18.noarch.rpm
python-django-devserver.noarch: W: spelling-error Summary(en_US) runserver ->
run server, run-server, server
python-django-devserver.noarch: W: spelling-error %description -l en_US
runserver -> run server, run-server, server
python-django-devserver.noarch: W: spelling-error %description -l en_US
werkzeug -> westernize
python-django-devserver.noarch: W: spelling-error %description -l en_US multi
-> mulch, mufti
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
>>> Would be nice to have, especially since the github repo
contains the
package with a license file
[!]: The documentation is not being copied
>>> Would be nice to have
Generated by fedora-review 0.1.3
External plugins:
*** NOT APPROVED ***
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.