Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jpanoramamaker -
https://bugzilla.redhat.com/show_bug.cgi?id=638582
Summary: Review Request: jpanoramamaker - Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jvanek@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker.spec SRPM URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker-5.1.src.tar.gz (or https://koji.fedoraproject.org/koji/taskinfo?taskID=2496498)
Description: Tool for stitching photos to panorama in linear curved space
This is my first package and I'm looking for sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |akurtako@redhat.com AssignedTo|nobody@fedoraproject.org |akurtako@redhat.com Flag| |fedora-review?
--- Comment #1 from Alexander Kurtakov akurtako@redhat.com 2010-09-29 08:38:41 EDT --- I'll take this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #2 from Alexander Kurtakov akurtako@redhat.com 2010-09-29 08:58:24 EDT --- Can you provide the src.rpm file?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #3 from jiri vanek jvanek@redhat.com 2010-09-29 09:02:37 EDT --- https://koji.fedoraproject.org/koji/getfile?taskID=2496498&name=jpanoram...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #4 from Alexander Kurtakov akurtako@redhat.com 2010-09-29 09:25:55 EDT --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [ ] Rpmlint output: jpanoramamaker.noarch: W: no-manual-page-for-binary jpanoramamaker jpanoramamaker-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese Not a problem.
[X] Package is named according to the Package Naming Guidelines. [X] Spec file name must match the base package name, in the format %{name}.spec. [X] Package meets the Packaging Guidelines. [X] Package successfully compiles and builds into binary rpms. [X] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [X] License field in the package spec file matches the actual license. License type: [X] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [X] All independent sub-packages have license of their own [X] Spec file is legible and written in American English. [X] Sources used to build the package matches the upstream source, as provided in the spec URL. [X] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [X] Package must own all directories that it creates. [X] Package requires other packages for directories it uses. [X] Package does not contain duplicates in %files. [X] Permissions on files are set properly. [X] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [X] Package consistently uses macros. [X] Package contains code, or permissable content. [X] Fully versioned dependency in subpackages, if present. [!] Package contains a properly installed %{name}.desktop file if it is a GUI application. [X] Package does not own files or directories owned by other packages. [X] Javadoc documentation files are generated and included in -javadoc subpackage [X] Packages have proper BuildRequires/Requires on jpackage-utils [X] Javadoc subpackages have Require: jpackage-utils [X] Package uses %global not %define [X] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [X] If source tarball includes bundled jar/class files these need to be removed prior to building [X] All filenames in rpm packages must be valid UTF-8.
=== Other suggestions === [X] If possible use upstream build method (maven/ant/javac) [X] Javadocs are placed in %{_javadocdir}/%{name} with %{_javadocdir}/%{name}-%{version} symlink [X] If package contains pom.xml files install it (including depmaps) even when building with ant [X] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [X] Latest version is packaged. [X] Reviewer should test that the package builds in mock.
=== Issues === 1. Missing desktop file for a GUI application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #5 from jiri vanek jvanek@redhat.com 2010-09-29 11:47:15 EDT --- updated SRPM http://koji.fedoraproject.org/koji/getfile?taskID=2496851&name=jpanorama... in http://koji.fedoraproject.org/koji/taskinfo?taskID=2496850
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #6 from Alexander Kurtakov akurtako@redhat.com 2010-09-29 12:07:29 EDT --- There are 2 problems: 1. You haven't added a changelog entry describing your change and haven't bump Release. You have to do that on every change. 2. desktop file and icon are installed as exectables which is wrong. Please use the default permissions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #7 from jiri vanek jvanek@redhat.com 2010-09-30 06:13:25 EDT --- repaired SRPM: http://koji.fedoraproject.org/koji/getfile?taskID=2503154&name=jpanorama...
for http://koji.fedoraproject.org/koji/taskinfo?taskID=2503153
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #8 from Alexander Kurtakov akurtako@redhat.com 2010-09-30 06:19:08 EDT --- Thanks, This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #9 from Alexander Kurtakov akurtako@redhat.com 2010-09-30 06:21:54 EDT --- Sponsored.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from jiri vanek jvanek@redhat.com 2010-09-30 07:25:25 EDT --- New Package SCM Request ======================= Package Name: jpanoramamaker Short Description: Tool for stitching photos to panorama in linear curved space. Owners: jvanek Branches: f12 f13 f14 InitialCC: jvanek
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2010-10-03 16:35:43 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-10-04 03:53:38
--- Comment #12 from jiri vanek jvanek@redhat.com 2010-10-04 03:53:38 EDT --- all builds on koji passed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-10-04 04:00:52 EDT --- jpanoramamaker-5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/jpanoramamaker-5-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-10-04 04:07:13 EDT --- jpanoramamaker-5-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/jpanoramamaker-5-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-10-12 08:46:55 EDT --- jpanoramamaker-5-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |jpanoramamaker-5-2.fc14 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-10-14 02:27:32 EDT --- jpanoramamaker-5-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=638582
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|jpanoramamaker-5-2.fc14 |jpanoramamaker-5-2.fc13
package-review@lists.fedoraproject.org