https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Bug ID: 2031377 Summary: Review Request: rit-tnjoy-fonts - OpenType font for Malayalam script Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rajeeshknambiar@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-tnjoy-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-tnjoy-fonts-1.4-0.fc35.src... Description: A traditional orthography Malayalam Unicode font Fedora Account System Username: rajeeshknambiar
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Rajeesh rajeeshknambiar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |pnemade@redhat.com, | |vvijayra@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Parag Nemade pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|pnemade@redhat.com |
--- Comment #1 from Parag Nemade pnemade@redhat.com --- I prefer different bugzilla account for package reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Summary|Review Request: |Review Request: |rit-tnjoy-fonts - OpenType |rit-tn-joy-fonts - A |font for Malayalam script |traditional orthography | |font for Malayalam script CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review Suggestion: 1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file BuildRequires: fontpackages-devel Requires: fontpackages-filesystem
2) New fonts packaging guidelines need the font family name as its written in font file. For this package its "TN Joy" and the font package name will be <foundry>-<FontFamily>-fonts. Thus for this package its rit-tn-joy-fonts.
3) Submit new SPEC and SRPM links.
4) conf file path is empty in SPEC. Change %global fontconfs %{nil} to %global fontconfs meta/67-tnjoy-fonts.conf
5) Also, you need to change the "TNJoy" to "TN Joy" in 67-tnjoy-fonts.conf file. As the Font family to match is "TN Joy".
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
--- Comment #3 from Rajeesh rajeeshknambiar@gmail.com --- Thank you.
A new upstream release is also made, and SPEC+SRPM updated.
SPEC: https://rajeeshknambiar.fedorapeople.org/spec/rit-tn-joy-fonts.spec SRPM: https://rajeeshknambiar.fedorapeople.org/srpm/rit-tn-joy-fonts-1.4.1-0.fc35....
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- Thank you for the update. The changes looks good to me.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rit-tn-joy-fonts
https://bugzilla.redhat.com/show_bug.cgi?id=2031377
Rajeesh rajeeshknambiar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|ASSIGNED |CLOSED Last Closed| |2021-12-28 13:48:31
package-review@lists.fedoraproject.org