Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226138
Summary: Merge Review: metacity Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: sandmann@redhat.com
Fedora Merge Review: metacity
http://cvs.fedora.redhat.com/viewcvs/devel/metacity/ Initial Owner: sandmann@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: metacity
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226138
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
Bug 226138 depends on bug 203547, which changed state.
Bug 203547 Summary: split a metacity-devel package + missing dependency https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203547
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: metacity
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226138
------- Additional Comments From Jochen@herr-schmitt.de 2007-04-03 12:31 EST ------- Bad: - Local build failed: + cd metacity-2.18.0 + LANG=C + export LANG + unset DISPLAY + rm -rf /var/tmp/metacity-2.18.0-1-root-s4504kr + CPPFLAGS=' -I/var/tmp/metacity-2.18.0-1-root-s4504kr/usr/include' + export CPPFLAGS + autoreconf src/Makefile.am: required file `./compile' not found autoreconf: automake failed with exit status: 1 Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.46901 (%build)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: metacity
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226138
------- Additional Comments From pertusus@free.fr 2007-04-04 03:41 EST ------- * a remark the gettext_package, metacity_version and metacity_filename don't seem to be usefull to me, %{name}, %{version} and %{name}-%{version} would seem more natural to me
* -I$RPM_BUILD_ROOT%{_includedir} seems wrong to me. Why is it there? CPPFLAGS="$CPPFLAGS -I$RPM_BUILD_ROOT%{_includedir}"
* Why run autoreconf?
* on the make line, CPPFLAGS="$CPPFLAGS" LIBS="$LIBS" seems unuseful to me, while %{?_smp_mflags} is missing (it worked in my tests)
* The pkgconfig Requires is unuseful in main package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: metacity
https://bugzilla.redhat.com/show_bug.cgi?id=226138
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
------- Additional Comments From debarshi.ray@gmail.com 2008-06-15 04:34 EST ------- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: metacity
https://bugzilla.redhat.com/show_bug.cgi?id=226138
------- Additional Comments From sandmann@redhat.com 2008-06-16 15:13 EST ------- I am happy enough for someone to just go ahead and fix these things. I don't believe metacity has any ACL's.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226138
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com, | |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226138
--- Comment #5 from Parag AN(पराग) panemade@gmail.com 2010-10-18 04:42:52 EDT --- Created attachment 454045 --> https://bugzilla.redhat.com/attachment.cgi?id=454045 spec cleanup
Please commit this git patch that will clean this package for this review or allow to commit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226138
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed| |2010-10-22 00:36:31
--- Comment #6 from Parag AN(पराग) panemade@gmail.com 2010-10-22 00:36:31 EDT --- Committed the above patch and built in metacity-2.30.3-2.fc15
APPROVED.
package-review@lists.fedoraproject.org