https://bugzilla.redhat.com/show_bug.cgi?id=2273016
Bug ID: 2273016 Summary: Review Request: python-numba - Compiling Python code using LLVM Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: gwync@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Description: Compiling Python code using LLVM
SRPM: https://fedorapeople.org/~limb/review/python-numba/python-numba-0.59.1-1.fc4... SPEC: https://fedorapeople.org/~limb/review/python-numba/python-numba.spec
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |benson_muite@emailplus.org Resolution|--- |DUPLICATE Status|NEW |CLOSED Last Closed| |2024-04-03 18:09:34
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Reviewing 2271634, but feel free to take the review as will not get to it before the weekend.
*** This bug has been marked as a duplicate of bug 2271634 ***
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|CLOSED |NEW Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- So I've updated my package to 0.60.0 and I've started patching for Python versions, but many of the threading calls are different in ways I'm not confident in altering. It looks like 0.61.0 will be out soon, I'll see if that's better.
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- The Arch and Suse packages seem ok:
https://gitlab.archlinux.org/archlinux/packaging/packages/python-numba/-/blo... https://build.opensuse.org/projects/openSUSE:Factory/packages/python-numba/f...
CUDA license is likely not acceptable: https://docs.nvidia.com/cuda/archive/11.2.2/eula/index.html https://github.com/numba/numba/blob/main/LICENSES.third-party#L496
Should the entire cuda subdirectory be removed?
It may be helpful to provide 3 builds: a) without OpenMP and without TBB b) with OpenMP and without TBB c) without OpenMP and with TBB
https://numba.readthedocs.io/en/stable/user/installing.html
Initial build: https://copr.fedorainfracloud.org/coprs/fed500/python-numba/build/8452585/
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- Oh, gosh, how I love CPU-specific options.
We should probably drop cuda. Regarding OpenMP and TBB, I think it would be better to use per-arch conditionals to build with them where available.
Does that work for you?
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- OpenMP should work everywhere. Am less sure about OneTBB, official support is for x86_64 though the Fedora spec file does not have any architecture limitations and the tests are run. Main problem with threading is more likely that a user code which uses threading and then calls numba may create threading problems. In these cases, it is good to have a serial option without OpenMP or TBB. Probably modules similar to what is done for MPI would be the cleanest option. However, would start doing a build with neither OpenMP or TBB, then add these afterwards. This would at least get things working and allow other software to use numba, even if performance would not be the best possible.
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- That makes sense. I've prepped my spec with that, and will await 0.61.0.
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- Related issue upstream https://github.com/numba/numba/issues/9881
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #8 from Peter Robinson pbrobinson@gmail.com ---
We should probably drop cuda. Regarding OpenMP and TBB, I think it would be better to use per-arch conditionals to build with them where available.
I've not seen issues for some time (likely years) on TBB on different arches so I think it should be fine. OpenMP is widely supported across all arches. I would start with a single build with them both and if there's issues show up address them then as they're likely bugs anyway.
Where are we generally with this review? 0.61.2 is out with support for numpy 2.2.
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
--- Comment #9 from Gwyn Ciesla gwync@protonmail.com --- SPEC: https://fedorapeople.org/~limb/review/python-numba/python-numba.spec SRPM: https://fedorapeople.org/~limb/review/python-numba/python-numba-0.61.2-1.fc4...
Build fails if I remove cuda. Import tests fail if I leave it in place.
https://bugzilla.redhat.com/show_bug.cgi?id=2273016
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://numba.pydata.org
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9100092 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org