https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Bug ID: 2089349 Summary: Review Request: python-objgraph - objgraph is a module that lets you visually explore Python object graphs. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: thrnciar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... Description: objgraph is a module that lets you visually explore Python object graphs. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Tomáš Hrnčiar thrnciar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... Description: objgraph is a module that lets you visually explore Python object graphs. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Tomáš Hrnčiar thrnciar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... Description: objgraph is a module that lets you visually explore Python object graphs. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Tomáš Hrnčiar thrnciar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... Description: objgraph is a module that lets you visually explore Python object graphs. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |mhroncok@redhat.com Status|NEW |ASSIGNED
--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Please fix the summary:
python3-objgraph.noarch: W: summary-not-capitalized objgraph is a module that lets you visually explore Python object graphs. python3-objgraph.noarch: W: summary-ended-with-dot objgraph is a module that lets you visually explore Python object graphs.
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- python-objgraph.src: W: summary-not-capitalized objgraph is a module that lets you visually explore Python object graphs. python3-objgraph.noarch: W: summary-not-capitalized objgraph is a module that lets you visually explore Python object graphs. python-objgraph.src: W: summary-ended-with-dot objgraph is a module that lets you visually explore Python object graphs. python3-objgraph.noarch: W: summary-ended-with-dot objgraph is a module that lets you visually explore Python object graphs.
Rpmlint (installed packages) ---------------------------- python3-objgraph.noarch: W: summary-not-capitalized objgraph is a module that lets you visually explore Python object graphs. python3-objgraph.noarch: W: summary-ended-with-dot objgraph is a module that lets you visually explore Python object graphs.
Source checksums ---------------- https://files.pythonhosted.org/packages/source/o/objgraph/objgraph-3.5.0.tar... : CHECKSUM(SHA256) this package : 4752ca5bcc0e0512e41b8cc4d2780ac2fd3b3eabd03b7e950a5594c06203dfc4 CHECKSUM(SHA256) upstream package : 4752ca5bcc0e0512e41b8cc4d2780ac2fd3b3eabd03b7e950a5594c06203dfc4
Requires -------- python3-objgraph (rpmlib, GLIBC filtered): python(abi) = 3.10 python3.10dist(graphviz)
BuildRequires ------------- pyproject-rpm-macros python3-devel python3dist(graphviz) python3dist(packaging) python3dist(pip) >= 19 python3dist(setuptools) >= 40.8 python3dist(tox-current-env) >= 0.0.6 python3dist(wheel)
Provides -------- python3-objgraph: python-objgraph = 3.5.0-1.fc37 python3-objgraph = 3.5.0-1.fc37 python3.10-objgraph = 3.5.0-1.fc37 python3.10dist(objgraph) = 3.5 python3dist(objgraph) = 3.5
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-objgraph --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, C/C++, PHP, SugarActivity, Haskell, Java, R, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
--- Comment #2 from Tomáš Hrnčiar thrnciar@redhat.com --- Thank you for the review. Here is an updated specfile with a fixed summary.
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-objgraph/... Description: Objgraph is a module that lets you visually explore Python object graphs Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- What about not repeating the package name:
A Python module that lets you visually explore Python object graphs
Anyway, APPROVED, but please don't import unless you are sure you want to maintain it just for the sake of the leaktests in greenlet.
https://bugzilla.redhat.com/show_bug.cgi?id=2089349
Tomáš Hrnčiar thrnciar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DEFERRED Status|POST |CLOSED Last Closed| |2022-06-09 13:21:24
--- Comment #4 from Tomáš Hrnčiar thrnciar@redhat.com --- We decided not to include python-objgraph into Fedora for now.
package-review@lists.fedoraproject.org