Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pyvnc2swf - Vnc screen recorder
https://bugzilla.redhat.com/show_bug.cgi?id=448201
------- Additional Comments From dtimms(a)iinet.net.au 2008-06-21 08:40 EST -------
(In reply to comment #7)
The Bash trick should really be unnecessary: your package is noarch,
so even on
64-bit systems the files will be in /usr/lib/pythonX.Y/... , never
/usr/lib64/pythonX.Y/... . The invocation you're using actually returns
OK, I
reread the Packaging/Python info, and see where it's coming from: I
thought that %sitelib would be /usr/lib64 on x86_64, but as you mention this is
noarch.
Put this at the top of the specfile:
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
Updated
the sitelib assignment.
But do you really need to do this? edit.py works just fine if you
symlink it.
Likewise with vnc2swf itself. I'd suggest just symlinking them all to /usr/bin.
OK. Without the need to determine the final arch specific location of the *.py,
yes, I can simply use a symlink, done for the 3x command line tools.
Could not reproduce the ImportError you're getting -- movie comes
from pyvnc2swf
so I'm not sure why you're getting that. Is that from *after* you install the
RPM or before?
Here is a test case:
1. vncserver :1
2. vnc2swf
3. options|server|localhost:1
4. start
5. stop
6. save as test.swf
7. exit
8. vnc2swf-play test.swf
result:
vnc2swf-play ~/dev/pytest.swf
Using pygame 1.7.1release
Input movie: version=5, size=1024x768, framerate=12fps, frames=187, duration=15.6s.
Output movie size: 1024x768
Scanning source swf file: /home/davidt/dev/pytest.swf...
Traceback (most recent call last):
File "/usr/bin/vnc2swf-play", line 267, in <module>
play(args, info, debug=debug)
File "/usr/bin/vnc2swf-play", line 234, in play
PygameMoviePlayer(movie, debug=debug).play()
File "/usr/bin/vnc2swf-play", line 165, in play
self.builder.start()
File "/usr/lib/python2.5/site-packages/pyvnc2swf/output.py", line 942, in
start
self.stream.open()
File "/usr/bin/vnc2swf-play", line 79, in open
import pymedia
ImportError: No module named pymedia
===
Since fedora now has a flash player, I removed the play.py script and symlink.
Note that the recordwin script has, hardbaked into it, x11vnc and
xwininfo.
x11vnc is part of libvncserver, but apparently it's not shipped in the Fedora
package at all. You might want to file a bug asking for it to be included, and
meanwhile, %exclude %{_bindir}/recordwin.sh from the %files section?
Yes, disabled
recordwin for now. It looks to me like x11vnc is a separate part
of the libvncserver project:
http://sourceforge.net/project/showfiles.php?group_id=32584
edit.py throws some exceptions if called without the right arguments;
you might
want to fix the code path so that if any argument is missing, it exits after
displaying the error messages rather than attempting (futilely) to continue.
Created a patch that changes the return into a sys.exit. This seems to work well
to show the usage and exit at that point.
updated spec:
http://members.iinet.net.au/~timmsy/pyvnc2swf/pyvnc2swf.spec
src.rpm:
http://members.iinet.net.au/~timmsy/pyvnc2swf/pyvnc2swf-0.9.3-2.fc9.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.