https://bugzilla.redhat.com/show_bug.cgi?id=1525984
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com ---
As for the %py2_install/%py3_install macros, I attempted to use those originally, but they failed with the following error:
- /usr/bin/python2 setup.py install -O1 --skip-build --root
/home/jsmith/Build/BUILDROOT/python-ruamel-std-pathlib-0.6.3-2.fc28.x86_64 error: you have to install with "pip install ." error: Bad exit status from /var/tmp/rpm-tmp.qH8GI7 (%install)
I'd appreciate any help figuring out why that's failing. (I'm no expert at setup.py, but it appears that it throws that message if the "--single-version-externally-managed" isn't passed in.)
I tried %py2_install/%py3_install in my initial review too to see why you didn't use them and had the same error, but now reading the source code, it appears you can use an environment variable to bypass the check:
%install RUAMEL_NO_PIP_INSTALL_CHECK=1 %py2_install %if %{with python3} RUAMEL_NO_PIP_INSTALL_CHECK=1 %py3_install %endif
- Be more specific in %files:
%files -n python2-%{pname} %license LICENSE %doc README.rst %{python2_sitelib}/ruamel/ %{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/ %{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth
%if %{with python3} %files -n python%{python3_pkgversion}-%{pname} %license LICENSE %doc README.rst %{python3_sitelib}/ruamel/ %{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/ %{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth %endif
package-review@lists.fedoraproject.org