https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Bug ID: 1254820 Summary: Review Request: php-firephp-firephp-core - Traditional FirePHPCore library for sending PHP variables to the browser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn.iwinski@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ca66707e00bb51d150d7dc73c9ed...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-firephp-firephp-core-0.4.0-1.fc2...
Description: FirePHP is an advanced logging system that can display PHP variables in the browser as an application is navigated. All communication is out of band to the application meaning that the logging data will not interfere with the normal functioning of the application.
Fedora Account System Username: siwinski
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-firephp-firephp-core
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 1065824 --> https://bugzilla.redhat.com/attachment.cgi?id=1065824&action=edit phpci.log
phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:09:02 CEST static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 1065825 --> https://bugzilla.redhat.com/attachment.cgi?id=1065825&action=edit review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Remi Collet fedora@famillecollet.com --- - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file README.md is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
=> README.md and each PHP files contain the fulll License text. This is enough to comply with MIT License terms.
Upstream also add the LICENSE.txt file, so this will be part of next update.
[!]: Spec file according to URL is the same as in SRPM. => Minor acceptable diff (spl not required, so github version is ok)
No Blocker.
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- THANKS for the review!
New Package SCM Request ======================= Package Name: php-firephp-firephp-core Short Description: Traditional FirePHPCore library for sending PHP variables to the browser Upstream URL: https://github.com/firephp/firephp-core Owners: siwinski Branches: f21 f22 f23 el6 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7771
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14148
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14149
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14150
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7772
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update php-firephp-firephp-core'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14149
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update php-firephp-firephp-core'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14148
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update php-firephp-firephp-core'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14150
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update php-firephp-firephp-core'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7771
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update php-firephp-firephp-core'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7772
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.4.0-1.fc23 Resolution|--- |NEXTRELEASE Last Closed| |2015-09-05 21:10:57
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.0-1.fc23 |0.4.0-1.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.0-1.fc22 |0.4.0-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.0-1.fc21 |0.4.0-1.fc23
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.0-1.fc23 |0.4.0-1.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- php-firephp-firephp-core-0.4.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1254820
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.0-1.el6 |0.4.0-1.el7
package-review@lists.fedoraproject.org