https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Bug ID: 1881572 Summary: Review Request: golang-github-projectdiscovery-cdncheck - Filter to check for CDN IP addresses during port scanning Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-c... SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-c...
Project URL: https://github.com/projectdiscovery/cdncheck
Description: A filter to check for CDN IP addresses during port scanning.
Koji scratch build: fails due to missing dependency
rpmlint output: $ rpmlint golang-github-projectdiscovery-cdncheck-0-0.1.20200922git19e1db6.fc32.src.rpm golang-github-projectdiscovery-cdncheck.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint golang-github-projectdiscovery-cdncheck-devel-0-0.1.20200922git19e1db6.fc32.noarch.rpm golang-github-projectdiscovery-cdncheck-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/projectdiscovery/cdncheck/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881562 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881562 [Bug 1881562] Review Request: golang-github-yl2chen-cidranger - Fast IP to CIDR lookup in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1881363
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881363 [Bug 1881363] naabu-2.0.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1881611
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881611 [Bug 1881611] Review Request: golang-github-projectdiscovery-httpx - Fast and multi-purpose HTTP toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Bump to latest commit before import
- Tests fail, Seems they need network access:
Testing in: /builddir/build/BUILD/cdncheck-19e1db650e26adfbd81f1e01c66633f7d1ab7e3c/_build/src PATH: /builddir/build/BUILD/cdncheck-19e1db650e26adfbd81f1e01c66633f7d1ab7e3c/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/cdncheck-19e1db650e26adfbd81f1e01c66633f7d1ab7e3c/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags " -X github.com/projectdiscovery/cdncheck/version=0 -X github.com/projectdiscovery/cdncheck/version.commit=19e1db650e26adfbd81f1e01c66633f7d1ab7e3c -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" testing: github.com/projectdiscovery/cdncheck github.com/projectdiscovery/cdncheck --- FAIL: TestCDNCheck (0.00s) cdncheck_test.go:12: Error Trace: cdncheck_test.go:12 Error: Expected nil, but got: &url.Error{Op:"Get", URL:"https://ipinfo.io/AS12222", Err:(*net.OpError)(0xc000072690)} Test: TestCDNCheck Messages: Could not create cdncheck client --- FAIL: TestScrapeRanges (0.00s) --- FAIL: TestScrapeRanges/cloudflare (0.00s) ranges_test.go:27: Error Trace: ranges_test.go:27 Error: Expected nil, but got: &url.Error{Op:"Get", URL:"https://www.cloudflare.com/ips-v4", Err:(*net.OpError)(0xc0000727d0)} Test: TestScrapeRanges/cloudflare Messages: Could not scrape cloudflare --- FAIL: TestScrapeRanges/incapsula (0.00s) ranges_test.go:31: Error Trace: ranges_test.go:31 Error: Expected nil, but got: &url.Error{Op:"Post", URL:"https://my.incapsula.com/api/integration/v1/ips", Err:(*net.OpError)(0xc0000728c0)} Test: TestScrapeRanges/incapsula Messages: Could not scrape incapsula --- FAIL: TestScrapeRanges/akamai (0.00s) ranges_test.go:35: Error Trace: ranges_test.go:35 Error: Expected nil, but got: &url.Error{Op:"Get", URL:"https://ipinfo.io/AS12222", Err:(*net.OpError)(0xc0000729b0)} Test: TestScrapeRanges/akamai Messages: Could not scrape akamai --- FAIL: TestScrapeRanges/sucuri (0.00s) ranges_test.go:39: Error Trace: ranges_test.go:39 Error: Expected nil, but got: &url.Error{Op:"Get", URL:"https://ipinfo.io/AS30148", Err:(*net.OpError)(0xc000072aa0)} Test: TestScrapeRanges/sucuri Messages: Could not scrape sucuri FAIL exit status 1 FAIL github.com/projectdiscovery/cdncheck 0.008s
https://bugzilla.redhat.com/show_bug.cgi?id=1881572 Bug 1881572 depends on bug 1881562, which changed state.
Bug 1881562 Summary: Review Request: golang-github-yl2chen-cidranger - Fast IP to CIDR lookup in Golang https://bugzilla.redhat.com/show_bug.cgi?id=1881562
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for your input.
%changelog * Mon Nov 16 10:01:13 CET 2020 Fabian Affolter mail@fabian-affolter.ch - 0-0.2.20201116git5bc57c3 - Tests requires network access (#1881572) - Update to latest commit
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56756864
Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-c... https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-c...
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- + Please package published version instead of a git commit:
https://github.com/projectdiscovery/cdncheck/releases/tag/v0.0.1
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
--- Comment #4 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
--- Comment #5 from Mohan Boddu mboddu@bhujji.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-cdncheck
https://bugzilla.redhat.com/show_bug.cgi?id=1881572
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2021-08-27 20:11:22
package-review@lists.fedoraproject.org