https://bugzilla.redhat.com/show_bug.cgi?id=1381132
Bug ID: 1381132 Summary: Review Request: python-wikipedia - Wikipedia API for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@alice.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.4-1.gitb...
Description: Search Wikipedia, get article summaries, get data like links and images from a page, and more.
Fedora Account System Username: martinkg
rpmlint -i python-wikipedia.spec /home/martin/rpmbuild/SRPMS/python-wikipedia-1.4.4-1.gitb329024.fc24.src.rpm /home/martin/rpmbuild/RPMS/noarch/python2-wikipedia-1.4.4-1.gitb329024.fc24.noarch.rpm /home/martin/rpmbuild/RPMS/noarch/python3-wikipedia-1.4.4-1.gitb329024.fc24.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
%changelog * Sun Oct 02 2016 Martin Gansser martinkg@fedoraproject.org - 1.4.4-1.gitb329024 - Initial package
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/barrust/ | |Wikipedia
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1359914
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1359914 [Bug 1359914] Review Request: lollypop - Music player for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
Dominika Krejčí dkrejci@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dkrejci@redhat.com
--- Comment #1 from Dominika Krejčí dkrejci@redhat.com --- Hi Martin, I have some comments.
* The last version of barrust/Wikipedia is 1.4.5 and the commit used in `Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version` tag?
* The `Source0` url creates directory with ugly name, it should be named `%{srcname}-%{version}.tar.gz`.
* It is useless to create a %{sum} macro. Just write the content to `Summary` and in the rest of the file you can use %{summary} marco. ;)
* Rather then `python-requests` be more specific and use `python2-requests`, wherever it is possible.
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #2 from MartinKG mgansser@alice.de --- Hi Dominika,
(In reply to Dominika Krejčí from comment #1)
Hi Martin, I have some comments.
- The last version of barrust/Wikipedia is 1.4.5 and the commit used in
`Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version` tag?
ok update to new version
- The `Source0` url creates directory with ugly name, it should be named
`%{srcname}-%{version}.tar.gz`.
done
- It is useless to create a %{sum} macro. Just write the content to
`Summary` and in the rest of the file you can use %{summary} marco. ;)
done
- Rather then `python-requests` be more specific and use `python2-requests`,
wherever it is possible.
done
New rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.5-1.fc24...
%changelog * Fri Oct 14 2016 Martin Gansser martinkg@fedoraproject.org - 1.4.5-1 - Update to 1.4.5-1 - Cleanup spec file - Use Requires python2-requests - Write the content to Summary and in the rest use %%{summary} marco
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #3 from Dominika Krejčí dkrejci@redhat.com --- You can also update these: -> python2-requests -> python2-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #4 from MartinKG mgansser@alice.de --- New rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.5-2.fc24...
%changelog * Tue Oct 18 2016 Martin Gansser martinkg@fedoraproject.org - 1.4.5-2 - Update to BR python2-requests - Update to BR python2-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #5 from MartinKG mgansser@alice.de --- Hi Dominika, can you do a review ?
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
Dominika Krejčí dkrejci@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |dkrejci@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
Dominika Krejčí dkrejci@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Dominika Krejčí dkrejci@redhat.com --- Hi Martin, everything is ok. Package APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python2-wikipedia-1.4.5-2.fc26.noarch.rpm python3-wikipedia-1.4.5-2.fc26.noarch.rpm python-wikipedia-1.4.5-2.fc26.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python2-wikipedia (rpmlib, GLIBC filtered): python(abi) python-beautifulsoup4 python2-requests
python3-wikipedia (rpmlib, GLIBC filtered): python(abi) python3-beautifulsoup4 python3-requests
Provides -------- python2-wikipedia: python-wikipedia python2-wikipedia python2.7dist(wikipedia) python2dist(wikipedia)
python3-wikipedia: python3-wikipedia python3.5dist(wikipedia) python3dist(wikipedia)
Source checksums ---------------- https://github.com/barrust/Wikipedia/archive/v1.4.5.tar.gz#/wikipedia-1.4.5.... : CHECKSUM(SHA256) this package : 825dd4cd6c2594d282e75aadd1bca1b4a22c49537360a2de067428c416af487c CHECKSUM(SHA256) upstream package : 825dd4cd6c2594d282e75aadd1bca1b4a22c49537360a2de067428c416af487c
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1381132 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #7 from MartinKG mgansser@alice.de --- Hi Dominika, many thanks for your review !
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-wikipedia
https://bugzilla.redhat.com/show_bug.cgi?id=1381132
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2016-10-21 10:06:54
--- Comment #9 from MartinKG mgansser@alice.de --- package has been built successfully on fc23, fc24, fc25 and rawhide.
package-review@lists.fedoraproject.org