https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Bug ID: 2214842 Summary: Review Request: golang-github-vmihailenco-msgpack-5 - MessagePack encoding for Golang v5 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mikel@olasagasti.info QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-vmihailenco-msgpack-5... SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-vmihailenco-msgpack-5... Description: MessagePack encoding for Golang v5. Fedora Account System Username: mikelo2
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2214841 Doc Type|--- |If docs needed, set a value Blocks| |2120430
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2120430 [Bug 2120430] golang-github-zclconf-cty-1.13.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=2214841 [Bug 2214841] Review Request: golang-github-vmihailenco-tagparser-2 - Opinionated Golang tag parser
https://bugzilla.redhat.com/show_bug.cgi?id=2214842 Bug 2214842 depends on bug 2214841, which changed state.
Bug 2214841 Summary: Review Request: golang-github-vmihailenco-tagparser-2 - Opinionated Golang tag parser https://bugzilla.redhat.com/show_bug.cgi?id=2214841
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |daron439@gmail.com
--- Comment #1 from Pavel Solovev daron439@gmail.com --- build fails with - nothing provides golang(cloud.google.com/go/logging) needed by golang-google-grpc-devel-1.48.0-7.fc38.noarch from fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
--- Comment #2 from Mikel Olasagasti Uranga mikel@olasagasti.info --- It is because https://src.fedoraproject.org/rpms/golang-cloud-google was retired yesterday. I pinged Major and he confirmed he will restore the package as it is required by some packages.
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- golang-cloud-google issue has been fixed, package should build fine now
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |daron439@gmail.com Flags| |fedora-review+
--- Comment #4 from Pavel Solovev daron439@gmail.com --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-vmihailenco-msgpack-5
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-572eb2fa6c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-572eb2fa6c
https://bugzilla.redhat.com/show_bug.cgi?id=2214842
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-06-19 08:00:07
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-572eb2fa6c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org