Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895810
Tom "spot" Callaway <tcallawa(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tcallawa(a)redhat.com
Assignee|nobody(a)fedoraproject.org |tcallawa(a)redhat.com
Flags| |fedora-review+
--- Comment #1 from Tom "spot" Callaway <tcallawa(a)redhat.com> ---
I'm not going to get too meta here and discuss the viability of trying to
describe the license of a package which just contains license files. That might
be fun some other time though. :)
= Review =
Good:
- rpmlint checks return:
glassfish-legal.src: W: invalid-url Source0: glassfish-legal-1.1-src-svn.tar.gz
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff due to SVN checkout)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vw5uUxaWIj&a=cc_unsubscribe