https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Bug ID: 2217491 Summary: Review Request: python-zombie-imp - A copy of the `imp` module that was removed in Python 3.12 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: thrnciar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... Description: A particularly mischevious act of necromancy. That is, A copy of the imp module that was removed in Python 3.12.
Don't use this, it'll probably trick and bite you. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Karolina Surma ksurma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ksurma@redhat.com Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ksurma@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #1 from Karolina Surma ksurma@redhat.com --- fedora-review is broken in Rawhide apparently due to dnf5 issue: https://github.com/rpm-software-management/dnf5/issues/635 I'll inspect the built Rawhide RPMs and use the results from F38 review as a partial workaround.
Specfile: It looks pretty standard, just one nitpick: Consider adding to the package description a tad more serious explanation why it's actually packaged to Fedora - the current one raises more questions than answers.
RPM: The tests are not running during the build: build.log contains these lines:
+ /usr/bin/python3 -m tox --current-env -q --recreate -e py311 py311: OK (0.00 seconds) congratulations :) (0.03 seconds)
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #2 from Karolina Surma ksurma@redhat.com --- Except for the tests, the rest looks good. Please post the updated specfile with running %check.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== FOUND ISSUES =====
[!]: %check is present and all tests pass. Note: no tests run.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #3 from Tomáš Hrnčiar thrnciar@redhat.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... Description: A particularly mischevious act of necromancy. That is, A copy of the imp module that was removed in Python 3.12.
Don't use this, it'll probably trick and bite you. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/encukou/ | |zombie-imp
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6118035 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #5 from Tomáš Hrnčiar thrnciar@redhat.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... Description: A copy of the imp module that was removed in Python 3.12. This is a compat package to ease transition to Python 3.12. It shouldn't be used and packages using `imp` module should use `importlib.metadata` instead. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1972804 --> https://bugzilla.redhat.com/attachment.cgi?id=1972804&action=edit The .spec file difference from Copr build 6118035 to 6118163
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6118163 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #8 from Karolina Surma ksurma@redhat.com --- Shouldn't the line `Provides: deprecated()` be placed within the python3-zombie-imp instead of python-zombie-imp?
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #9 from Tomáš Hrnčiar thrnciar@redhat.com --- Oh, you are right.
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-zombie-im... Description: A copy of the imp module that was removed in Python 3.12. This is a compat package to ease transition to Python 3.12. It shouldn't be used and packages using `imp` module should use `importlib.metadata` instead. Fedora Account System Username: thrnciar
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1972819 --> https://bugzilla.redhat.com/attachment.cgi?id=1972819&action=edit The .spec file difference from Copr build 6118163 to 6118322
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6118322 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Karolina Surma ksurma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #12 from Karolina Surma ksurma@redhat.com --- Deprecated provides is present
$ rpm -qP python3-zombie-imp-0.0.2-1.fc39.noarch.rpm deprecated() python-zombie-imp = 0.0.2-1.fc39 python3-zombie-imp = 0.0.2-1.fc39 python3.11-zombie-imp = 0.0.2-1.fc39 python3.11dist(zombie-imp) = 0.0.2 python3dist(zombie-imp) = 0.0.2
Tests run and pass.
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #13 from Miro Hrončok mhroncok@redhat.com --- Why not:
%pyproject_save_files zombie_imp imp
Instead of:
%files -n python3-zombie-imp -f %{pyproject_files} ... %{python3_sitelib}/__pycache__/imp.cpython-* %{python3_sitelib}/imp.py
?
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
--- Comment #14 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-zombie-imp
https://bugzilla.redhat.com/show_bug.cgi?id=2217491
Tomáš Hrnčiar thrnciar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NEXTRELEASE Status|POST |CLOSED Last Closed| |2023-06-27 16:18:00
package-review@lists.fedoraproject.org