Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710452
--- Comment #4 from Mukund Sivaraman <muks(a)banu.com> 2011-06-04 02:39:44 EDT ---
Hi Nils, Jussi :)
Thank you for reviewing it so quickly. I have made the necessary changes:
(In reply to comment #3)
BAD: The license as in LICENSE is acceptable for Fedora, but unzix.c
is
licensed as "Copyright (C) 2009 Mukund Sivaraman. All rights reserved."
without
a mention of the BSD license. I know you're a good guy and won't use this
against someone, but this needs to be fixed ;-). For the remainder of the
review I'm assuming that the stated new BSD license holds.
I have changed the source code accordingly, and have made a new release. You
can browse the code here:
https://banu.com/cgit/unzix/
BAD: rpmlint indicates errors:
unzix.x86_64: E: explicit-lib-dependency zlib
unzix.x86_64: W: empty-%pre
unzix.x86_64: W: empty-%post
unzix.x86_64: W: empty-%preun
unzix.x86_64: W: empty-%postun
3 packages and 1 specfiles checked; 1 errors, 4 warnings.
Removed.
--> remove "Requires: zlib", empty scriptlets
Removed.
CHECK: Spec file must be written in American English: In the
description it's
probably rather "... extracting files from archives in the WinZix format."
(I'd
leave out "new" as this will change over time) and the changelog entry should
rather be "Initial rpm package" or "... packaging" IMO. Language
lawyering
works best late in the evening ;-).
Changed.
(In reply to comment #2)
- In case the man page compression format changes, it's better to
use
%{_mandir}/man1/%{name}.1.*
instead of
%{_mandir}/man1/%{name}.1.gz
Changed.
----
The new files can be browsed here:
http://mukund.org/tmp/unzix.spec-2
(the "-2" is a temporary URL suffix so you can diff the changes from orig)
http://mukund.org/tmp/unzix-0.3.0-1.fc14.src.rpm
Please review them and tell me if all looks good. :)
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.