Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: spice-protocol - Spice protocol header files
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Summary: Review Request: spice-protocol - Spice protocol header files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kraxel@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://kraxel.fedorapeople.org/review/spice-protocol/spice-protocol.spec SRPM URL: http://kraxel.fedorapeople.org/review/spice-protocol/spice-protocol-0.5.2-1.... Description: Header files describing the spice protocol and the para-virtual graphics card QXL.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com
--- Comment #1 from Matthias Clasen mclasen@redhat.com 2010-07-09 15:03:38 EDT --- Builds fine in mock.
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/stats.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/qxl_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vdi_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/barrier.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/ipc_ring.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/macros.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/spice-protocol.pc spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/enums.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vd_agent.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/start-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/end-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/protocol.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/error_codes.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/types.h 2 packages and 0 specfiles checked; 0 errors, 14 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
--- Comment #2 from Matthias Clasen mclasen@redhat.com 2010-07-09 15:04:06 EDT --- The license field in the spec file looks wrong.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
--- Comment #3 from Matthias Clasen mclasen@redhat.com 2010-07-09 15:14:04 EDT --- package name: ok spec file name: ok packaging guidelines: ok, but if the package is only meant for F13+, then some cleanups are possible: - drop BuildRoot - drop initial rm -rf in %install - drop %clean section license: ok license file: ok license field: should be BSD, not GPLv2+ spec language: ok spec readable: yes upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok (pedants prefer the 4-argument form of %defattr) macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok (the wording of the guidelines is a bit unfortunate here...) static libs: ok shared libs: ok libtool archives: ok devel deps: ok gui apps: ok file ownership: ok utf8 filenames: ok
Summary: - fix the license - apply minor cleanups at your discretion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
--- Comment #4 from Gerd Hoffmann kraxel@redhat.com 2010-07-12 03:38:32 EDT --- Updated package + specfile are uploaded to http://kraxel.fedorapeople.org/review/spice-protocol/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #5 from Matthias Clasen mclasen@redhat.com 2010-07-12 09:43:29 EDT --- Looks good now. Approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Gerd Hoffmann kraxel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Gerd Hoffmann kraxel@redhat.com 2010-07-12 11:05:02 EDT --- New Package CVS Request ======================= Package Name: spice-protocol Short Description: Spice protocol header files Owners: kraxel alexl Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2010-07-12 13:25:49 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612943
Gerd Hoffmann kraxel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
--- Comment #8 from Gerd Hoffmann kraxel@redhat.com 2010-07-13 08:38:50 EDT --- rawhide builds are done.
package-review@lists.fedoraproject.org