https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Bug ID: 2069415 Summary: Review Request: rust-ciborium-ll - Low-level CBOR codec primitives Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/rust-ciborium-ll.spec SRPM: https://pbrobinson.fedorapeople.org/rust-ciborium-ll-0.2.0-1.fc36.src.rpm
Description: Low-level CBOR codec primitives
FAS: pbrobinson
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2069413 (rust-ciborium-io)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2069413 [Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |rust-ciborium-ll
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2069418 (rust-ciborium)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2069418 [Bug 2069418] Review Request: rust-ciborium - Serde implementation of CBOR using ciborium-basic
https://bugzilla.redhat.com/show_bug.cgi?id=2069415 Bug 2069415 depends on bug 2069413, which changed state.
Bug 2069413 Summary: Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage https://bugzilla.redhat.com/show_bug.cgi?id=2069413
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- You replaced the link to the LICENSE file with the correct one, but the SRPM still contains the GitHub HTML page, same as what happened with the ciborium-io package. Please fix this.
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
--- Comment #2 from Peter Robinson pbrobinson@gmail.com --- (In reply to Fabio Valentini from comment #1)
You replaced the link to the LICENSE file with the correct one, but the SRPM still contains the GitHub HTML page, same as what happened with the ciborium-io package. Please fix this.
Fixed
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (ASL 2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ciborium-ll
https://bugzilla.redhat.com/show_bug.cgi?id=2069415
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-05-13 06:29:31
package-review@lists.fedoraproject.org