[Bug 2240100] New: Review Request: merkuro - A calendar application using Akonadi to sync with external services (Nextcloud, GMail, ...)
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Bug ID: 2240100 Summary: Review Request: merkuro - A calendar application using Akonadi to sync with external services (Nextcloud, GMail, ...) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: farchord@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://api.nicehomeservices.com/images/temp/merkuro.spec SRPM URL: https://api.nicehomeservices.com/images/temp/merkuro-23.08.1-1.fc40.src.rpm Description: A calendar application using Akonadi to sync with external services (Nextcloud, GMail, ...) Fedora Account System Username: farchord
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Spec review notes:
%if 0%{?fedora} || 0%{?epel} > 7 # handled by qt5-srpm-macros, which defines %%qt5_qtwebengine_arches # Package doesn't build on arches that qtwebengine is not built on. ExclusiveArch: %{qt5_qtwebengine_arches} %endif
The conditional can be dropped, as it's always true for all places this is packaged.
You are also missing an Obsoletes+Provides set:
Obsoletes: kalendar < 23.08 Provides: kalendar = %{version}-%{release} Provides: kalendar%{?_isa} = %{version}-%{release}
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #3 from Steve Cossette farchord@gmail.com --- Done, I have removed the conditional (Still kept what was inside of it though ofc) and added the obsolete/provides set.
I also did some quick housekeeping with proper tab spacing in the spec.
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(ngompa13@gmail.co | |m) |
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint * Package upgrade transition correctly handled
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/merkuro
https://bugzilla.redhat.com/show_bug.cgi?id=2240100
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |COMPLETED Status|POST |CLOSED Last Closed| |2023-10-01 16:48:45
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com