Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: qt-assistant-adp - Compatibility version of Qt Assistant
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Summary: Review Request: qt-assistant-adp - Compatibility version of Qt Assistant Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kevin@tigcc.ticalc.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://repo.calcforge.org/f14/qt-assistant-adp.spec SRPM URL: http://apt.kde-redhat.org/apt/kde-redhat/SRPMS.kde/unstable/qt-assistant-adp... (152.7 MiB) Description: The old version of Qt Assistant, based on Assistant Document Profile (.adp) files, and the associated QtAssistantClient library, for compatibility with applications providing help in that format.
New applications should use the new version of Qt Assistant introduced in Qt 4.4, based on the Qt Help Framework also introduced in Qt 4.4, instead.
This is built from the Qt 4.6.2 tarball (thus the huge SRPM), as Qt 4.7 no longer includes this deprecated library/class/tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2010-03-13 15:39:08 EST --- 1. avoiding Conflicts Since this is targeted for qt-4.7.0 anyway, we can possibly skip the Conflicts, and do something like this instead:
BuildRequires: qt4-devel >= 4.7.0
Requires qt4%{?_isa} >= %{_qt4_version}
I won't consider this a review blocker, but let's do our best to resolve the issue prior to releasing any builds.
Naming: ok
scriplets: ok
licensing: ok
macros: ok
no .desktop file: documented justification for exception, ok.
Otherwise, fairly simple and clean.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
--- Comment #2 from Kevin Kofler kevin@tigcc.ticalc.org 2010-03-13 15:47:37 EST --- The Conflicts are all versioned so as not to conflict with the current version. I don't see where the problem is there. It's quite a common idiom to have that kind of versioned Conflicts and we're also using it in other places in KDE. AIUI, the spirit of the guidelines is to avoid Conflicts between the current versions of packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2010-03-13 16:21:41 EST --- True, still, having a qt4 runtime dependency is largely required anyway, and by adding it, removes the need for conflicts in the first place.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org 2010-03-13 17:57:58 EST --- New Package CVS Request ======================= Package Name: qt-assistant-adp Short Description: Compatibility version of Qt Assistant Owners: kkofler than rdieter ltinkl Branches: InitialCC: tuxbrewr
At this time, we only need this in devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
--- Comment #5 from Tom "spot" Callaway tcallawa@redhat.com 2010-03-15 18:04:39 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2010-04-21 13:22:01 EDT --- imported/built for rawhide awhile back.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #7 from Kevin Kofler kevin@tigcc.ticalc.org 2010-10-19 15:38:20 EDT --- Package Change Request ====================== Package Name: qt-assistant-adp New Branches: F-13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Kevin Kofler kevin@tigcc.ticalc.org 2010-10-19 15:50:11 EDT --- Package Change Request ====================== Package Name: qt-assistant-adp New Branches: f13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr
Fixed the branch name.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2010-10-21 09:27:00 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org