Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-functest - Functional test framework
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Summary: Review Request: python-functest - Functional test framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kklic@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://kklic.fedorapeople.org/python-functest.spec SRPM URL: http://kklic.fedorapeople.org/python-functest-0.8.8-1.fc16.src.rpm Description: Functional test framework with no boiler plate code, setup/teardown module hierarchies, and distributed result reporting.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
--- Comment #1 from Karel Klíč kklic@redhat.com 2012-01-30 05:44:58 EST --- rpmlint python-functest-0.8.8-1.fc17.noarch.rpm
python-functest.noarch: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.noarch: W: no-documentation python-functest.noarch: W: no-manual-page-for-binary functest 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
- http://en.wiktionary.org/wiki/teardown#English - no-documentation: the upstream archive doesn't contain any documentation - no-manual-page-for-binary: we should deal with it later
rpmlint python-functest-0.8.8-1.fc17.src.rpm
python-functest.src: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.src:7: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src: W: invalid-url Source0: python-functest-0.8.8.tar.xz 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
- The %{version} macro is used intentionally in the comments. - The project does not release tarballs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Karel Klíč kklic@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |786093
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mrunge@matthias-runge.de AssignedTo|nobody@fedoraproject.org |mrunge@matthias-runge.de Flag| |fedora-review?
--- Comment #2 from Matthias Runge mrunge@matthias-runge.de 2012-02-01 02:19:21 EST --- I'll take this one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Matthias Runge mrunge@matthias-runge.de 2012-02-01 03:50:05 EST --- Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent.
rpmlint python-functest-0.8.8-1.fc17.src.rpm
python-functest.src: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.src:7: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src: W: invalid-url Source0: python-functest-0.8.8.tar.xz 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
rpmlint python-functest-0.8.8-1.fc17.noarch.rpm
python-functest.noarch: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.noarch: W: no-documentation python-functest.noarch: W: no-manual-page-for-binary functest 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Issues: [!]: MUST Rpmlint output is silent.
rpmlint python-functest-0.8.8-1.fc17.src.rpm
python-functest.src: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.src:7: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src:8: W: macro-in-comment %{version} python-functest.src: W: invalid-url Source0: python-functest-0.8.8.tar.xz 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
rpmlint python-functest-0.8.8-1.fc17.noarch.rpm
python-functest.noarch: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-functest.noarch: W: no-documentation python-functest.noarch: W: no-manual-page-for-binary functest 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Two sidenotes: - you should change buildrequires from python-devel to python2-devel
(cf. https://fedoraproject.org/wiki/Packaging:Python#BuildRequires )
- you should include a check section: %check %{__python} setup.py test
== APPROVED ==
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Karel Klíč kklic@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Karel Klíč kklic@redhat.com 2012-02-02 06:26:32 EST --- Thank you for the review. I have adjusted the spec file according to your recommendations.
New Package SCM Request ======================= Package Name: python-functest Short Description: Functional test framework Owners: kklic Branches: f16 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-02-02 08:40:34 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-02-02 09:53:36 EST --- python-functest-0.8.8-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-functest-0.8.8-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-02-02 09:53:46 EST --- python-functest-0.8.8-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-functest-0.8.8-1.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-02-03 20:05:37 EST --- python-functest-0.8.8-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-functest-0.8.8-1.el6 Resolution| |ERRATA Last Closed| |2012-02-18 16:43:45
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-02-18 16:43:45 EST --- python-functest-0.8.8-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785681
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-functest-0.8.8-1.el6 |python-functest-0.8.8-1.fc1 | |6
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-02-18 20:57:01 EST --- python-functest-0.8.8-1.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org