https://bugzilla.redhat.com/show_bug.cgi?id=1175601
Ken Dreyer <ktdreyer(a)ktdreyer.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ktdreyer(a)ktdreyer.com
Assignee|nobody(a)fedoraproject.org |ktdreyer(a)ktdreyer.com
Flags| |fedora-review+
--- Comment #1 from Ken Dreyer <ktdreyer(a)ktdreyer.com> ---
There are two small issues, neither one blocks review. PACKAGE APPROVED.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- gem2rpm left trailing whitespace after "BuildRequires: rubygems-devel "
- There is an rpmlint error: rubygem-glu.x86_64: E: zero-length
/usr/lib64/gems/ruby/glu-8.2.1/gem.build_complete . Feel free to delete this
file as you've done with the others.
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). They are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package uses %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Package does not contain Requires: ruby(abi).
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contain
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec uses %global instead of %define unless justified.
Ruby:
[x]: Specfile should use macros from rubygem-devel package.
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: rubygem-glu-8.2.1-1.fc22.x86_64.rpm
rubygem-glu-doc-8.2.1-1.fc22.noarch.rpm
rubygem-glu-8.2.1-1.fc22.src.rpm
rubygem-glu.x86_64: W: spelling-error Summary(en_US) opengl -> opening
rubygem-glu.x86_64: W: spelling-error %description -l en_US opengl -> opening
rubygem-glu.x86_64: E: zero-length
/usr/lib64/gems/ruby/glu-8.2.1/gem.build_complete
rubygem-glu.src: W: spelling-error Summary(en_US) opengl -> opening
rubygem-glu.src: W: spelling-error %description -l en_US opengl -> opening
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
$ rpmlint rubygem-glu rubygem-glu-doc
rubygem-glu.x86_64: W: spelling-error Summary(en_US) opengl -> opening
rubygem-glu.x86_64: W: spelling-error %description -l en_US opengl -> opening
rubygem-glu.x86_64: E: zero-length
/usr/lib64/gems/ruby/glu-8.2.1/gem.build_complete
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
Requires
--------
rubygem-glu (rpmlib, GLIBC filtered):
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libc.so.6()(64bit)
libcrypt.so.1()(64bit)
libdl.so.2()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libruby.so.2.1()(64bit)
rtld(GNU_HASH)
ruby(rubygems)
rubygem-glu-doc (rpmlib, GLIBC filtered):
rubygem-glu
Provides
--------
rubygem-glu:
rubygem(glu)
rubygem-glu
rubygem-glu(x86-64)
rubygem-glu-doc:
rubygem-glu-doc
Unversioned so-files
--------------------
rubygem-glu: /usr/lib64/gems/ruby/glu-8.2.1/glu/glu.so
Source checksums
----------------
https://rubygems.org/gems/glu-8.2.1.gem :
CHECKSUM(SHA256) this package :
aa690eda6439dac8459d5b265f8020c480f2e51bfb6c653ab5ff5946022bffaf
CHECKSUM(SHA256) upstream package :
aa690eda6439dac8459d5b265f8020c480f2e51bfb6c653ab5ff5946022bffaf
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1175601
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component