https://bugzilla.redhat.com/show_bug.cgi?id=1526071
Bug ID: 1526071 Summary: Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-de... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-de... Description: Like setTimeout, but with arguments reversed Fedora Account System Username: jsmith
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- + /usr/bin/mocha -R spec module.js:538 throw err; ^ Error: Cannot find module 'coffee-script/register'
→ You need one more BR for the tests:
BuildRequires: npm(coffee-script)
With that: - license is ok - package builds in mock - latest version is packaged - tests are successful - no rpmlint issues
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- Sorry about that -- please try these versions instead.
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-de... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-de...
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Jared Smith jsmith.fedora@gmail.com --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/3558
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-call-delayed
https://bugzilla.redhat.com/show_bug.cgi?id=1526071
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-12-15 11:27:22
--- Comment #6 from Jared Smith jsmith.fedora@gmail.com --- In rawhide, closing bug
package-review@lists.fedoraproject.org