Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812132
--- Comment #9 from David Cantrell <dcantrell(a)redhat.com> 2012-05-07 16:46:19 EDT
---
(In reply to comment #8)
(In reply to comment #7)
> 2) Having the source archive be a gzipped tar file but named "v1.1" is
bad
> form. Please correct this. See
>
https://fedoraproject.org/wiki/Packaging/SourceURL for more information on
> options here. github presents a challenge because there is not a good way for
> us to reference tar.gz downloads and it is up to the maintainer to create
> those, though if you are also upstream I would recommend creating those.
OK will do.
Much better now, thanks.
> 3) The license in the spec file is correctly noted as LGPLv2+,
but the source
> archive contains both a copy of the GPLv2+ and LGPLv2+. Reading the code, I
> see no mention of GPL-only licensed code. It's all LGPL. I would recommend
> removing the GPLv2+ COPYING file and just keeping the LGPLv2+ file. In fact,
> the FSF distributes that file as COPYING.LIB (see
>
ftp://ftp.gnu.org/gnu/Licenses/), which is the name I recommend you use rather
> than COPYING.LESSER
I went by this:
http://www.gnu.org/licenses/gpl-howto.html
which renames COPYING.LIB to COPYING.LESSER and recommends COPYING also
included since COPYING.LESSER builds on COPYING.
I have left it as-is for now, but am fine with either way.
Huh, well that page is new to me. I find the FSF's suggestions on how to cram
the GPL in to every piece of software is a little unnecessary. If the license
is LGPL, just include that text. But that's just me. I have no problems if
you want to keep it this way.
> 4) The source archive unpacks to agrover-python-lvm-3363431,
which is a little
> confusing. If you are generating this archive, please make it
> %{name}-%{version}.
Will do.
Updated:
Spec URL:
http://fedorapeople.org/~grover/new/python-lvm.spec
SRPM URL:
http://repos.fedorapeople.org/repos/grover/target/fedora-17/SRPMS/python-...
Looks clean, will post updated rpmlint and build output.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.