https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Bug ID: 1447213 Summary: Review Request: gimp-wavelet-decompose - Decomposing image plug-in for Gimp Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: luya@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://luya.fedorapeople.org/packages/SPECS/gimp-wavelet-decompose.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/gimp-wavelet-decompose-0-1.fc25... Description: Script-Fu script for lossless decomposing an image into different detail scales useful for photo post processing (for instance repairing skin in portraits). Fedora Account System Username: luya
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jsmith.fedora@gmail.com Assignee|nobody@fedoraproject.org |jsmith.fedora@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: =======
You should request the license text be included upstream. But since that's a SHOULD item and not a MUST, I won't block the review for that one item.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Personal/Reviews/1447213-gimp-wavelet- decompose/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM.
Installation errors ------------------- INFO: mock.py version 1.4.1 starting (python version = 3.6.1)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init INFO: installing package(s): /home/jsmith/Documents/Personal/Reviews/1447213-gimp-wavelet-decompose/results/gimp-wavelet-decompose-0-1.fc27.noarch.rpm
Rpmlint ------- Checking: gimp-wavelet-decompose-0-1.fc27.noarch.rpm gimp-wavelet-decompose-0-1.fc27.src.rpm gimp-wavelet-decompose.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless gimp-wavelet-decompose.noarch: W: no-documentation gimp-wavelet-decompose.src: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires -------- gimp-wavelet-decompose (rpmlib, GLIBC filtered): gimp
Provides -------- gimp-wavelet-decompose: gimp-wavelet-decompose
Source checksums ---------------- http://registry.gimp.org/files/wavelet-decompose.scm : CHECKSUM(SHA256) this package : 62aa6d5f92b89bdc9664c955bea717cf9d6b3a115d46a8f44493c0757ae21a79 CHECKSUM(SHA256) upstream package : 62aa6d5f92b89bdc9664c955bea717cf9d6b3a115d46a8f44493c0757ae21a79
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1447213 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #2 from Luya Tshimbalanga luya@fedoraproject.org --- Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gimp-wavelet-decompose
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-72eab41e91
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5fd0e0236c
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1391c40c06
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5fd0e0236c
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-72eab41e91
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1391c40c06
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-15 20:54:29
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1447213
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- gimp-wavelet-decompose-0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org