https://bugzilla.redhat.com/show_bug.cgi?id=1889768
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #3 from Miro Hrončok <mhroncok(a)redhat.com> ---
Spec sanity:
# Don't forget to also change oraculum/__init__.py
Is this spec file shared with upstream? I don't see this line relevant in
Fedora.
# Test requirements, we need to list these as there is no python3
builddep generator
But there is ;)
https://src.fedoraproject.org/rpms/pyproject-rpm-macros
The install section seems like a lot of code. Maybe this can be solved by
upstream Makefile or package_data? Let me know if I shall try doing the second
option.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sc...
mentions to BR systemd-rpm-macros. Is systemd/systemd-devel actually needed on
build time?
# Remove compiled .py files from /etc after os_install_post
rm -f %{buildroot}%{_sysconfdir}/testcloud/*.py{c,o}
rm -rf %{buildroot}%{_sysconfdir}/testcloud/__pycache__
Doing this in %check is ether a neat trick or a dirty hack, depending on the
perspective. Either way, no os_install_post action in Fedora currently
bytecompiles files in %{_sysconfdir}. Is it really needed? Especially the .pyo
thing seems a bit suspicious.
What Fedora/EPEL releases do you target with this spec file?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component