https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Bug ID: 1339004 Summary: Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl... Description: The package libintl-perl is an internationalization library for Perl that aims to be compatible with the Uniforum message translations system as implemented for example in GNU gettext.
Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
This is a re-review request for a package rename, since I want to rename this package from perl-libintl to perl-libintl-perl to bring it in line with the Naming Guidlines.
https://fedoraproject.org/wiki/Package_Renaming_Process https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28...
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-05-26 11:19:09
--- Comment #6 from Emmanuel Seyman emmanuel@seyman.fr --- That was fast... I've imported perl-libintl-perl and retired perl-libintl on the master branch.
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com QA Contact|extras-qa@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ppisar@redhat.com QA Contact|ppisar@redhat.com |extras-qa@fedoraproject.org
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: a597e128742e1c1c973a5e968626ef55eb270e8ecde793333c7a7247895f2431) is original. Ok. Summary and description verified from the old perl-libintl.spec. Ok.
FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare `LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources.
The license tag is Ok.
FIX: Build-require `perl-generators'. FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20).
version module is nowhere used. Ok. MyInstall.pm is executed during the build. Ok.
TODO: Do not build-require `perl(Carp)'. It's not used when running tests.
TODO: You can replace the `-exec rm' command with `-delete' to avoid executing `rm' in the %install section.
FIX: Tests fails for me: ./tests/03bind_textdomain_codeset_pp.t .. 1/14 # Test 8 got: "March" (./tests/03bind_textdomain_codeset_pp.t at line 74) # Expected: "M\xE4rz" # ./tests/03bind_textdomain_codeset_pp.t line 74 is: ok gettext ('March'), 'M�rz'; ./tests/03bind_textdomain_codeset_pp.t .. Failed 1/14 subtests (less 3 skipped subtests: 10 okay) [...] Test Summary Report ------------------- ./tests/03bind_textdomain_codeset_pp.t (Wstat: 0 Tests: 14 Failed: 1) Failed test: 8 ./tests/03dcgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2) Failed tests: 5, 9 ./tests/03dgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2) Failed tests: 5, 9 ./tests/03gettext_pp.t (Wstat: 0 Tests: 8 Failed: 1) Failed test: 5 ./tests/03ngettext_pp.t (Wstat: 0 Tests: 88 Failed: 10) Failed tests: 24-33 ./tests/03pgettext_pp.t (Wstat: 0 Tests: 8 Failed: 3) Failed tests: 5-7
This is because the ./tests/03bind_textdomain_codeset_pp.t test expects support de_AT locale. You have to build-require glibc-langpack-de.
$ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-1.fc25.src.rpm ../RPMS/x86_64/perl-libintl-perl-* perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: manifest-in-perl-module /usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ru.po perl-libintl-perl.x86_64: E: wrong-script-interpreter /usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL /usr/local/bin/perl perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/fr.po perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod perl-libintl-perl.x86_64: E: wrong-script-interpreter /usr/share/doc/perl-libintl-perl/sample/simplecal/bin/simplecal.pl /usr/local/bin/perl perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt_BR.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar_SA.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/it.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/de_AT.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ga.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/de.po perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/gettext_xs.pod 3 packages and 1 specfiles checked; 5 errors, 15 warnings. rpmlint is Ok.
TODO: Report the old FSF address. TODO: You could correct the shell bang in the examples not to use /usr/local/bin/perl.
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-libintl-perl-1.25-1.fc25.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libperl.so.5.24()(64bit) 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.4.0 1 perl(base) 1 perl(bytes) 1 perl(Carp) 1 perl(constant) 1 perl(Cwd) 1 perl(DynaLoader) 1 perl(Encode) 1 perl(Encode::Alias) 1 perl(Exporter) 1 perl(File::Spec) 1 perl(integer) 1 perl(IO::Handle) 1 perl(locale) 1 perl(Locale::gettext_pp) 1 perl(Locale::Messages) 1 perl(Locale::Recode::_Conversions) 1 perl(Locale::RecodeData) 1 perl(POSIX) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-libintl-perl-1.25-1.fc25.x86_64.rpm Binary dependencies resolvable. Ok.
FIX: This new package must conflicts or obsoletes perl-libintl package. The two clashes on files. I believe you need `Obsoletes: perl-libintl < 1.25'.
Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14244533). Ok.
TODO: List the optional run-time dependencies as Recommends or Suggests.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
--- Comment #2 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Petr Pisar from comment #1)
FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare `LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources.
Indeed. Fixed.
FIX: Build-require `perl-generators'. FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20).
Fixed.
TODO: Do not build-require `perl(Carp)'. It's not used when running tests.
TODO: You can replace the `-exec rm' command with `-delete' to avoid executing `rm' in the %install section.
Fixed.
FIX: Tests fails for me: [...] This is because the ./tests/03bind_textdomain_codeset_pp.t test expects support de_AT locale. You have to build-require glibc-langpack-de.
Wow, good catch. Fixed.
TODO: Report the old FSF address.
Done. This is ticket #114731 on CPAN's RT: https://rt.cpan.org/Public/Bug/Display.html?id=114731
TODO: You could correct the shell bang in the examples not to use /usr/local/bin/perl.
Done. I now also convert the non-UTF-8 files to UTF-8.
FIX: This new package must conflicts or obsoletes perl-libintl package. The two clashes on files. I believe you need `Obsoletes: perl-libintl < 1.25'.
I was convinced that a Provides was sufficient. Added.
TODO: List the optional run-time dependencies as Recommends or Suggests.
Done.
Spec URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl...
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Spec file changes:
--- perl-libintl-perl.spec.old 2016-05-24 00:12:27.000000000 +0200 +++ perl-libintl-perl.spec 2016-05-26 14:36:31.000000000 +0200 @@ -1,9 +1,9 @@ Summary: Internationalization library for Perl, compatible with gettext Name: perl-libintl-perl Version: 1.25 -Release: 1%{?dist} +Release: 2%{?dist} # gettext_xs/gettext_xs.pm: GPLv3+ -# gettext_xs/Makefile.PL: GPLv2+ +# gettext_xs/Makefile.PL: LGPLv2+ # lib/Locale/gettext_xs.pod: LGPLv2+ # lib/Locale/RecodeData.pm: GPLv3+ # lib/Locale/libintlFAQ.pod: LGPLv2+ @@ -13,12 +13,15 @@ Source: http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/libintl-perl-%%7Bversion%7... # this module was renamed in the f25 dev cycle Provides: perl-libintl = %{version}-%{release} +Obsoletes: perl-libintl < 1.25
BuildRequires: coreutils BuildRequires: findutils BuildRequires: gcc BuildRequires: make BuildRequires: perl +BuildRequires: perl-devel +BuildRequires: perl-generators BuildRequires: perl(Config) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(File::Find) @@ -28,7 +31,6 @@ # Run-time: BuildRequires: perl(base) BuildRequires: perl(bytes) -BuildRequires: perl(Carp) BuildRequires: perl(constant) BuildRequires: perl(Cwd) BuildRequires: perl(DynaLoader) @@ -44,6 +46,8 @@ BuildRequires: perl(File::ShareDir) BuildRequires: perl(I18N::Langinfo) # Tests: +# Needed for tests/03bind_textdomain_codeset_pp.t +BuildRequires: glibc-langpack-de BuildRequires: perl(File::Basename) BuildRequires: perl(Test) BuildRequires: perl(Test::Harness) @@ -51,6 +55,8 @@ Requires: perl(Carp) Requires: perl(Encode::Alias) Requires: perl(POSIX) +Recommends: perl(File::ShareDir) +Recommends: perl(I18N::Langinfo)
%{?perl_default_filter}
@@ -65,6 +71,14 @@ find -type f -exec chmod -x {} ; find lib/Locale gettext_xs ( -name '*.pm' -o -name '*.pod' ) \ -exec sed -i -e '/^#! /bin/false/d' {} ; +# Fix rpmlint errors and warnings +cd sample/simplecal +sed -i -e '1i#!%{__perl}' bin/simplecal.pl Makefile.PL +for file in po/*.po; do + iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \ + mv $file.new $file +done +
%build perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}" @@ -73,7 +87,7 @@ %install make pure_install DESTDIR=%{buildroot} find %{buildroot} -type f ( -name .packlist -o \ - -name '*.bs' -size 0 ) -exec rm -f {} ';' + -name '*.bs' -size 0 ) -delete %{_fixperms} %{buildroot}
%check @@ -88,6 +102,9 @@ %{_mandir}/man?/*
%changelog +* Wed May 25 2016 Emmanuel Seyman emmanuel@seyman.fr - 1.25-2 +- Take into account the re-review comments (#1339004) + * Sat May 21 2016 Emmanuel Seyman emmanuel@seyman.fr - 1.25-1 - Update package to 1.25-1 - Rename package to perl-libintl-perl, the module's name on CPAN
All the issues are fixed.
TODO: Build-require `glibc-common' for iconv tool in %prep section.
$ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-2.fc25.src.rpm ../RPMS/x86_64/perl-libintl-perl-* perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/gettext_xs.pod perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod perl-libintl-perl.x86_64: W: manifest-in-perl-module /usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST 3 packages and 1 specfiles checked; 2 errors, 5 warnings. rpmlint is Ok.
Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14261048). Ok.
Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-libintl-perl
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
--- Comment #5 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Petr Pisar from comment #3)
TODO: Build-require `glibc-common' for iconv tool in %prep section.
I've added this to my local copy so it will be imported in the repo.
Resolution: Package APPROVED.
Repo requested. Thank you for the review, Petr.
package-review@lists.fedoraproject.org