https://bugzilla.redhat.com/show_bug.cgi?id=2068463

--- Comment #1 from Akira TAGOH tagoh@redhat.com --- Updated: Spec URL: https://tagoh.fedorapeople.org/reviews/mrsw-biz-udgothic-fonts/mrsw-biz-udgo... SRPM URL: https://tagoh.fedorapeople.org/reviews/mrsw-biz-udgothic-fonts/mrsw-biz-udgo...

Product: Fedora Version: rawhide Component: Package Review

Parag AN(पराग) panemade@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Parag AN(पराग) panemade@gmail.com's needinfo: Bug 2068463: Review Request: mrsw-biz-udgothic-fonts - Morisawa BIZ UD Gothic fonts, Japanese typeface https://bugzilla.redhat.com/show_bug.cgi?id=2068463

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

Luya Tshimbalanga luya_tfz@thefinalzone.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |luya_tfz@thefinalzone.net Flags| |fedora-review? | |needinfo?(tagoh@redhat.com)

--- Comment #4 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Please update to v1.051 Update license to SPDX format i.e. OFL -> OFL-1.1.

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

Akira TAGOH tagoh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tagoh@redhat.com) |

--- Comment #5 from Akira TAGOH tagoh@redhat.com --- Updated.

Spec URL: https://download.copr.fedorainfracloud.org/results/tagoh/mrsw-biz-udgothic-f... SRPM URL: https://download.copr.fedorainfracloud.org/results/tagoh/mrsw-biz-udgothic-f...

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

--- Comment #7 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Created attachment 2005075 --> https://bugzilla.redhat.com/attachment.cgi?id=2005075&action=edit Review file for this package

``` %global fontfamily0 BIZ UDGothic %global fontsummary0 Morisawa BIZ UD Gothic fonts, Japanese typeface %global fonts0 fonts/ttf/BIZUDGothic-*.ttf %global fontconfs0 %{SOURCE1} %global fontdescription0 %{expand: %{common_description}

This package provides a non-propotional sans-serif font. }

%global fontfamily1 BIZ UDPGothic %global fontsummary1 Morisawa BIZ UD PGothic fonts, Japanese typeface %global fonts1 fonts/ttf/BIZUDPGothic-*.ttf %global fontconfs1 %{SOURCE2} %global fontdescription1 %{expand: %{common_description}

This package provides a propotional sans-serif font. }

Source0: https://github.com/googlefonts/morisawa-biz-ud-gothic/archive/refs/tags/v%%7... Source1: %{fontpkgname0}.fontconfig.conf Source2: %{fontpkgname1}.fontconfig.conf BuildRequires: fontpackages-devel BuildRequires: libappstream-glib ```

Will it be possible to differentiate both names in their packaged format to avoid confusion? We are almost there according to the review file.

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

--- Comment #9 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- It sounds good.

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2005131 --> https://bugzilla.redhat.com/attachment.cgi?id=2005131&action=edit The .spec file difference from Copr build 6769361 to 6773048

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

--- Comment #13 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 26064 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Reviewer should test that the package builds in mock.(test on COPR) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.

fonts: [!]: Run fc-query on all fonts in package. Note: Cannot find fc-query command, install fontconfig package to make a comprehensive font review. See: url: undefined [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined

Rpmlint ------- Checking: mrsw-biz-udgothic-fonts-all-1.051-2.fc40.noarch.rpm mrsw-biz-udgothic-fonts-1.051-2.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjnzjr45c')] checks: 31, packages: 2

mrsw-biz-udgothic-fonts-all.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.7 s

Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mrsw-biz-udgothic-fonts-all". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1

0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s

Source checksums ---------------- https://github.com/googlefonts/morisawa-biz-ud-gothic/archive/refs/tags/v1.0... : CHECKSUM(SHA256) this package : 73b7fc086ed39d00219437b68593e86aa535c8590d9975936f7f45e8b3f94bde CHECKSUM(SHA256) upstream package : 73b7fc086ed39d00219437b68593e86aa535c8590d9975936f7f45e8b3f94bde

Requires -------- mrsw-biz-udgothic-fonts-all (rpmlib, GLIBC filtered): mrsw-biz-udgothic-fonts mrsw-biz-udpgothic-fonts

Provides -------- mrsw-biz-udgothic-fonts-all: mrsw-biz-udgothic-fonts-all

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mrsw-biz-udgothic-fonts --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, fonts, Generic Disabled plugins: Ocaml, Python, PHP, Haskell, Perl, C/C++, SugarActivity, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

Akira TAGOH tagoh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |luya_tfz@thefinalzone.net

https://bugzilla.redhat.com/show_bug.cgi?id=2068463

Akira TAGOH tagoh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2024-01-12 11:57:32

--- Comment #16 from Akira TAGOH tagoh@redhat.com --- The package has been built in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=111653406

Thank you for you help!