https://bugzilla.redhat.com/show_bug.cgi?id=1757117
Bug ID: 1757117 Summary: Review Request: perl-TOML-Parser - Simple toml parser Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: yaneti@declera.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://declera.com/~yaneti/perl-TOML-Parser/perl-TOML-Parser.spec SRPM URL: http://declera.com/~yaneti/perl-TOML-Parser/perl-TOML-Parser-0.91-1.fc32.src... Description: Simple toml parser Fedora Account System Username: yaneti
https://bugzilla.redhat.com/show_bug.cgi?id=1757117
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1757117
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires are almost ok FIX: Please remove duplicity of 'perl(parent)' and add version constraint for 'perl(Module::Build::Tiny) >= 0.035'
$ rpm -qp --requires perl-TOML-Parser-0.91-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(constant) 1 perl(Encode) 1 perl(Exporter) >= 5.57 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(parent) 1 perl(strict) 1 perl(TOML::Parser::Tokenizer) 1 perl(TOML::Parser::Tokenizer::Strict) 1 perl(TOML::Parser::Util) 1 perl(Types::Serialiser) 1 perl(:VERSION) >= 5.10.0 1 perl(:VERSION) >= 5.8.5 1 perl(warnings) Binary requires are Ok.
$ rpm -qp --provides perl-TOML-Parser-0.91-1.fc32.noarch.rpm | sort | uniq -c 1 perl(TOML::Parser) = 0.91 1 perl-TOML-Parser = 0.91-1.fc32 1 perl(TOML::Parser::Tokenizer) 1 perl(TOML::Parser::Tokenizer::Strict) 1 perl(TOML::Parser::Util) Binary provides are Ok.
$ rpmlint ./perl-TOML-Parser* perl-TOML-Parser.noarch: W: file-not-utf8 /usr/share/doc/perl-TOML-Parser/README.md 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Rpmlint is ok
FIX: Remove '%clean' from spec file. The %clean section is not required.
Please correct all 'FIX' issues.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1757117
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-TOML-Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1757117
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-10-01 14:13:00
--- Comment #3 from Yanko Kaneti yaneti@declera.com --- Thanks. Fixed the FIXes. Built in rawhide
package-review@lists.fedoraproject.org