https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Bug ID: 1268698 Summary: Review Request: rubygem-guard-bundler - Guard gem for Bundler Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-... SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-... Description: Guard::Bundler automatically install/update your gem bundle when needed. Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Jaroslav Prokop jar.prokop@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jar.prokop@volny.cz
--- Comment #1 from Jaroslav Prokop jar.prokop@volny.cz --- Hi Ilya, I did informal review on your package and I found following:
* Group is not needed - Group tags are not needed currently, so you should delete lines: ~~~ Group: Development/Languages ~~~
~~~ Group: Documentation ~~~
* Tests are not working - Tests are not working properly, because it seems upstream didn't include spec folder in the gem. Please fix this.
* Include Runtime Dependencies - With tests I discovered there are runtime dependencies that need to be added. Please do so.
I did not discover other errors.
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Also grab the license from upstream:
https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Missing runtime deps:
Runtime Dependencies (3): bundler ~> 1.0 guard ~> 2.2 → not packaged guard-compat ~> 1.1 → not packaged
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
--- Comment #4 from Ilya Gradina ilya.gradina@gmail.com --- (In reply to Robert-André Mauchin from comment #2)
Also grab the license from upstream:
https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE
the license is already present
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
--- Comment #5 from Ilya Gradina ilya.gradina@gmail.com --- new spec: https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rub... new srpm: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-...
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1516328
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1516328 [Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #6 from Vít Ondruch vondruch@redhat.com --- * Remove Coveralls dependecy - We don't care about code coverage, so Coveralls pulls in just more unnecessary dependencies. Please remove the dependency. This might be the medicine:
~~~ # We don't care about code coverage. sed -i '/[cC]overalls/ s/^/#/' spec/spec_helper.rb ~~~
* Remove the rubygem(guard) dependnecy. - Is this dependency required? So far, I have not installed the package and it does not look to be required.
* Make sure the test suite is working. - It seems that spec_helper library needs to be explicitly loaded to run the test suite. - It seems that Gemfile is missing to execute some tests. This should help:
~~~ echo "source 'http://rubygems.org'" > Gemfile ~~~
- the "-Ilib" is not required - You don't have to delete the test suite after its execution.
https://bugzilla.redhat.com/show_bug.cgi?id=1268698 Bug 1268698 depends on bug 1516328, which changed state.
Bug 1516328 Summary: Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins https://bugzilla.redhat.com/show_bug.cgi?id=1516328
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
package-review@lists.fedoraproject.org