https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Bug ID: 1307149 Summary: Review Request: mkdocs-material - A material design theme for MkDocs Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: williamjmorenor@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material-0.1.1-1.fc24... Description: A material design theme for MkDocs Fedora Account System Username: williamjmorenor
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- I can review this
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13566708
naming: ok
sources: ok (mostly) 4d0a704ab73d2c4dafc313ec313362ea 0.1.1.tar.gz
1. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags so tarball name could be more legible (ie, be of the form: %{name}-%{version}.tar.gz)
2. license NOT ok, README.md explicitly mentions MIT, so this MUST be: License: MIT
$ rpmlint *.src.rpm mkdocs-material.src: W: no-version-in-last-changelog
3. SHOULD follow changelog guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#... all of which explicitly include the version-release of the package
macros: ok
scriptlets: ok (n/a)
please fix MUST item 2, and consider addressing SHOULD items 1,3 as well
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #3 from William Moreno williamjmorenor@gmail.com --- Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material-0.2.2-1.fc25...
Update to last release Fix license tag Fix changelog
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rdieter@math.unl. | |edu)
--- Comment #4 from William Moreno williamjmorenor@gmail.com --- Ping!
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(rdieter@math.unl. | |edu) |
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- Thanks for reminder, looks good.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #6 from William Moreno williamjmorenor@gmail.com --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mkdocs-material
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- mkdocs-material-0.2.2-1.fc24 mkdocs-cinder-0.9.3-1.fc24 mkdocs-basic-theme-1.0.1-3.fc24 mkdocs-alabaster-0.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1307149
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-05-20 13:42:25
package-review@lists.fedoraproject.org