https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Bug ID: 2038653 Summary: Review Request: rust-nu-engine - Core commands for nushell Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-engine.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-engine-0.42.0-1.fc35.src... Description: Core commands for nushell. Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038486, which changed state.
Bug 2038486 Summary: Review Request: rust-nu-source - Source string characterizer for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038486
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CANTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038505, which changed state.
Bug 2038505 Summary: Review Request: rust-nu-errors - Core error subsystem for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038505
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038469, which changed state.
Bug 2038469 Summary: Review Request: rust-nu-ansi-term - Library for ANSI terminal colors and styles (bold, underline) https://bugzilla.redhat.com/show_bug.cgi?id=2038469
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038637, which changed state.
Bug 2038637 Summary: Review Request: rust-nu-test-support - Support for writing Nushell tests https://bugzilla.redhat.com/show_bug.cgi?id=2038637
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038648, which changed state.
Bug 2038648 Summary: Review Request: rust-nu-data - Nushell data https://bugzilla.redhat.com/show_bug.cgi?id=2038648
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2038632, 2038642, 2038486, |2075626 |2038505, 2038637, 2038648 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2038486 [Bug 2038486] Review Request: rust-nu-source - Source string characterizer for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038505 [Bug 2038505] Review Request: rust-nu-errors - Core error subsystem for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038632 [Bug 2038632] Review Request: rust-nu-value-ext - Extension traits for values in Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038637 [Bug 2038637] Review Request: rust-nu-test-support - Support for writing Nushell tests https://bugzilla.redhat.com/show_bug.cgi?id=2038642 [Bug 2038642] Review Request: rust-nu-stream - Nushell stream https://bugzilla.redhat.com/show_bug.cgi?id=2038648 [Bug 2038648] Review Request: rust-nu-data - Nushell data https://bugzilla.redhat.com/show_bug.cgi?id=2075626 [Bug 2075626] Review Request: rust-nu-glob - Fork of glob
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-raw... COPR builds and review templates: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/4221853/
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Make sure to build rust-nu-glob and rust-nu-protocol before this package, otherwise it will have broken dependencies.
Did you disable the "plugin" feature on purpose, or did you just not regenerate the .spec file for 0.61.0?
+%package -n %{name}+plugin-devel +Summary: %{summary} +BuildArch: noarch + +%description -n %{name}+plugin-devel %{_description} + +This package contains library source intended for building other packages which +use the "plugin" feature of the "%{crate}" crate. + +%files -n %{name}+plugin-devel +%ghost %{crate_instdir}/Cargo.toml +
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- I disabled plugin on purpose, as it depends on nu-plugin which depends on nu-engine: https://crates.io/crates/nu-plugin/0.61.0/dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2038638 Depends On|2038638 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2038638 [Bug 2038638] Review Request: rust-nu-plugin - Nushell Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
❯ fedpkg request-repo rust-nu-engine 2038653 https://pagure.io/releng/fedora-scm-requests/issue/43716
❯ fedpkg request-branch --repo rust-nu-engine --all-releases https://pagure.io/releng/fedora-scm-requests/issue/43717 https://pagure.io/releng/fedora-scm-requests/issue/43718 https://pagure.io/releng/fedora-scm-requests/issue/43719
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-engine
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038636, which changed state.
Bug 2038636 Summary: Review Request: rust-nu-path - Path handling library for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038636
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4f48ae2d1a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-40a68fac9c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-43bd74ffd7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4f48ae2d1a *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-43bd74ffd7 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-40a68fac9c *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038612, which changed state.
Bug 2038612 Summary: Review Request: rust-nu-protocol - Core values and protocols for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038612
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2038652, which changed state.
Bug 2038652 Summary: Review Request: rust-nu-parser - Nushell parser https://bugzilla.redhat.com/show_bug.cgi?id=2038652
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-04-28 05:50:43
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038653 Bug 2038653 depends on bug 2075626, which changed state.
Bug 2075626 Summary: Review Request: rust-nu-glob - Fork of glob https://bugzilla.redhat.com/show_bug.cgi?id=2075626
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038653
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org