https://bugzilla.redhat.com/show_bug.cgi?id=988890
Bug ID: 988890 Summary: Review Request: rubygem-sass-twitter-bootstrap - Gem of the Twitter Bootstrap Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tdawson@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-sass-twitter-bootstrap.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-sass-twitter-bootstrap-2.0.... Description: A rails compatible gem for John Long's Sass conversion of the Twitter Bootstrap Fedora Account System Username: tdawson
https://bugzilla.redhat.com/show_bug.cgi?id=988890
--- Comment #1 from Troy Dawson tdawson@redhat.com --- RPMLINT VALUES: $ rpmlint rubygem-sass-twitter-bootstrap.spec rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.src.rpm rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.noarch.rpm rubygem-sass-twitter-bootstrap-doc-2.0.1-1.fc20.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
REASON FOR OLDER VERSION OF GEM: This package is for a couple of OpenShift packages that need this version. Upstream will not be able to update and test to the newer version of this gem for several months. There have been no security advisories about this gem that require the newer versions.
REASON FOR THE VENDOR DIRECTORY: We are following the footsteps of the rubygem-bootstrap-sass review[1]. That review consulted with the ruby-sig and the consensus was to leave the bundled javascript in until there are approved javascript guidelines.[2] [1] https://bugzilla.redhat.com/show_bug.cgi?id=982679 [2] https://lists.fedoraproject.org/pipermail/ruby-sig/2013-July/001389.html
LICENSE: The License is already in newer versions of the gem. When we are able to update to a newer version, we will use Upstreams file.
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Axilleas Pipinellis axilleas@archlinux.gr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |894524
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmahut@redhat.com Assignee|nobody@fedoraproject.org |mmahut@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tdawson@redhat.com Flags| |needinfo?(tdawson@redhat.co | |m)
--- Comment #2 from Marek Mahut mmahut@redhat.com --- Troy,
Thank you for this review request.
I think you're missing ruby(abi) in your Requires.
Other than that, this package looks fine to me. I'm attaching the scratch builds too.
rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=5671036 f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5671048 f19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5671046
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Troy Dawson tdawson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tdawson@redhat.co |needinfo+ |m) |
--- Comment #3 from Troy Dawson tdawson@redhat.com ---
ruby(abi) was replaced in Fedora 19 with ruby(release), which is in the spec file. I chose to not have a version (which is recommended) because there isn't anything to indicate it needs a version.
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Ruby_Compati...
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? needinfo+ |fedora-review+
--- Comment #4 from Marek Mahut mmahut@redhat.com --- Troy, good to know :) I missed that update. This review request is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=988890
--- Comment #5 from Troy Dawson tdawson@redhat.com --- New Package SCM Request ======================= Package Name: rubygem-sass-twitter-bootstrap Short Description: Gem of the Twitter Bootstrap Owners: tdawson Branches: f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Troy Dawson tdawson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=988890
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=988890
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-sass-twitter-bootstrap-2.0.1...
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=988890
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-sass-twitter-bootst | |rap-2.0.1-1.fc19 Resolution|--- |ERRATA Last Closed| |2013-08-09 23:57:26
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=988890
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org