https://bugzilla.redhat.com/show_bug.cgi?id=1494915
Iwicki Artur <fedora(a)svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)svgames.pl
--- Comment #2 from Iwicki Artur <fedora(a)svgames.pl> ---
env BUILDING_FROM_RPMBUILD=yes make ...
I believe using /bin/env
inside spec files is discouraged.
%__install -D -m 444 loolwsd.service
%{buildroot}%{_unitdir}/loolwsd.service
install -d -m 755 %{buildroot}%{_localstatedir}/adm/fillup-templates
Why the mix of
"install" and "%__install"? Non-macro forms of system
executables are preferred.
As for "%{buildroot}%{_sysconfdir}/cron.d/loolwsd.cron", I think it'd be
cleaner to use cat and a heredoc to create the file:
cat > output_file <<EOF
Line 1 of file.
Line 2 of file.
EOF
You could, alternatively, just create said file and add it as Source1.
%{_datadir}/%{name}/favicon.ico
%{_datadir}/%{name}/discovery.xml
%{_datadir}/%{name}/robots.txt
%{_datadir}/%{name}/loleaflet/*
This makes the package own the files inside
%{_datadir}/%{name}, but the
directory itself is unowned.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component