Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: resource-agents - Open Source HA Resource Agents for Red Hat Cluster
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Summary: Review Request: resource-agents - Open Source HA Resource Agents for Red Hat Cluster Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fdinitto@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://fabbione.fedorapeople.org/ras/01/resource-agents.spec SRPM URL: http://fabbione.fedorapeople.org/ras/01/resource-agents-3.0.0-1.alpha3.fc11.... Description: Red Hat Resource Agents provides a set of scripts to interface with several services to operate in a High Availability environment.
The resource-agents are, at this point in time, released together with cluster (srpm). Upstream has been evaluating for sometime the area that receives the most frequent updates. resource agents is one of them. by separating the agents into its own tarball and rpm it makes updates a lot simpler for everybody.
This package will replace parts of rgmanager rpm once approved (see also note in the spec file). rgmanager will be update accordingly at the right time as I don't want to break rgmanager functionalities in a transition phase while this package is reviewed.
thanks Fabio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
--- Comment #1 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-06 03:08:36 EDT --- As rawhide and upstream change, new versions of spec and srpm:
Spec URL: http://fabbione.fedorapeople.org/ras/02/resource-agents.spec SRPM URL: http://fabbione.fedorapeople.org/ras/02/resource-agents-3.0.0-1.alpha4.fc11....
Thanks Fabio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Jim Meyering meyering@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |meyering@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Jim Meyering meyering@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Jim Meyering meyering@redhat.com 2009-02-19 08:41:33 EDT --- looks fine (though the scripts need separate review). There was one "should" I pointed out (add LICENSE), and Fabio said he'd address it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |fedora-review?
--- Comment #3 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-19 08:53:35 EDT --- In order to address the LICENSE file missing, I'll have to release a new upstream tarball. It will happen this week so i don't think is a big blocker.
Jim, thanks a lot for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
--- Comment #4 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-20 00:26:22 EDT --- New Package CVS Request ======================= Package Name: resource-agents Short Description: Open Source HA Resource Agents for Red Hat Cluster Owners: fabbione Branches: devel InitialCC: fabbione
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-02-20 14:41:41 EDT --- Can the reviewer here please set the fedora-review flag to + if they approve this package? (Also, reviewer should assign this review to themselves and moved it to ASSIGNED).
reset fedora-cvs once thats done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
--- Comment #6 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-20 14:47:14 EDT --- Hi Kevin,
not sure this is a fall out from the new bugzilla packages but I got this email:
Jim Meyering meyering@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
together with Comment 2.
But even reloading the bugzilla page, the Flags (for me) were still set as fedora-review?
is this normal?
Fabio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
--- Comment #7 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-20 14:56:17 EDT --- Jim,
sorry I need to bother you with this again but it appears that for some reason, when I added fedora-cvs+, your fedora-review+ has been changed back to -.
I spoke to Kevin on IRC and for accounting reasons admins would prefer you to set the flag back to review+, otherwise it's all cleared up.
Thanks Fabio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Jim Meyering meyering@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |meyering@redhat.com Flag|fedora-review? |fedora-review+
--- Comment #8 from Jim Meyering meyering@redhat.com 2009-02-20 15:24:51 EDT --- Fabio, no problem.
I've just set the fedora-review flag to +, again, and listed myself in "assigned to".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
--- Comment #9 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-20 15:52:01 EDT --- New Package CVS Request ======================= Package Name: resource-agents Short Description: Open Source HA Resource Agents for Red Hat Cluster Owners: fabbione Branches: devel InitialCC: fabbione
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |petersen@redhat.com Flag|fedora-cvs? |fedora-cvs+
--- Comment #10 from Jens Petersen petersen@redhat.com 2009-02-24 06:17:25 EDT --- cvs done
But in future please include the main review conversation in bugzilla so there is some record of the review proper preserved for others to see: this is important.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #11 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-02-24 07:54:30 EDT --- 1157024 build (dist-f11, /cvs/pkgs:rpms/resource-agents/devel:resource-agents-3_0_0-4_alpha5_fc11) completed successfully
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Fabio Massimo Di Nitto fdinitto@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #12 from Fabio Massimo Di Nitto fdinitto@redhat.com 2009-03-03 02:08:18 EDT --- Package Change Request ====================== Package Name: resource-agents New Branches: F-10 Owners: fabbione
This was an oversight on my side (so yeah I take all the blame) from the original CVS request. The whole point of this package is to make updates simpler. So it needs to propagate into F-10 too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481731
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #13 from Kevin Fenzi kevin@tummy.com 2009-03-03 15:51:38 EDT --- cvs done.
package-review@lists.fedoraproject.org