Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-DBIx-Class-DynamicDefault - Automatically set and update fields
https://bugzilla.redhat.com/show_bug.cgi?id=504177
Summary: Review Request: perl-DBIx-Class-DynamicDefault - Automatically set and update fields Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/DBIx-Class-DynamicDefault OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DynamicDefault.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DynamicDefault-0.03-1....
Description: Automatically set and update fields with values calculated at runtime.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1393609
Additional Comment:
This is a new BR of DBIx::Class::DateTime::Epoch.
*rt-0.10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504177
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-06-05 00:27:54 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1393609 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 65f6772df56f6378edec315b22886f870d6bc3f1 DBIx-Class-DynamicDefault-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=14, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.23 cusr 0.02 csys = 0.27 CPU) + Package perl-DBIx-Class-DynamicDefault-0.03-1.fc12.noarch => Provides: perl(DBIx::Class::DynamicDefault) = 0.03 Requires: perl(parent) perl(strict) perl(warnings) + Not a GUI application
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504177
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2009-06-05 02:02:06 EDT --- New Package CVS Request ======================= Package Name: perl-DBIx-Class-DynamicDefault Short Description: Automatically set and update fields Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504177
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504177
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2009-06-05 17:38:48 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504177
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2009-06-08 21:44:29 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org