Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=629873
Matthias Clasen <mclasen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--- Comment #3 from Matthias Clasen <mclasen(a)redhat.com> 2010-09-25 20:31:32 EDT
---
package name: ok
spec file name: ok
packaging guidelines: ok, clearly better to have the pc file in the main
package here
license: ok
license file: ok
license field: ok
spec file language: ok
spec file readability: excellent
upstream sources: ok
buildable: ok
ExcludeArch: ok
BuildRequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
duplicate files: ok
file permissions: ok
macro use: ok
content: permissible
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
directory ownership: ok
utf8 filenames: ok
One thing I wonder about: do we need any dependencies for the gstreamer plugins
that are referred to in the effects ? Eg
PipelineDescription=frei0r-filter-sobel
in sobel.effect
Or do apps like cheese handle the absence of filters nicely (ie hide the effect
unless all required plugins are present) ?
Anyway, the package is fine,
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.