https://bugzilla.redhat.com/show_bug.cgi?id=1101043
--- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
(In reply to Ralf Corsepius from comment #3)
The fact you enabled perl mandates (MUSTFIX!) further Perl-related
changes
to the spec:
- BR: perl(Cwd), perl(strict)
Why? I can't find those anywhere in the guidelines.
- Add R: perl(:MODULE_COMPAT_%...) to *-perl
Ack, I missed this one.
I'd propose the following change to your spec:
# diff -u ming.spec.orig ming.spec
--- ming.spec.orig 2014-06-03 07:53:23.180652587 +0200
+++ ming.spec 2014-06-03 13:46:11.970988831 +0200
@@ -43,7 +43,13 @@
%package perl
Summary: A Perl module for generating Macromedia Flash files using the Ming
library
+Provides: perl-SWF = %{version}.%{release}
+Provides: perl-SWF%{_isa} = %{version}.%{release}
Was the dot (.) here intentional? I'd think it should be a dash (-)
The P: perl-SWF... are optional and just "convenience" to
perl-users.
Right. A good idea to add them, though.
The LD_LIBRARY_PATH change would pickup shared libraries from
RPM_BUILD_ROOT
instead of the build-tree. It's an option I consider to be superior. (Sorry
for having missed this possiblity in my previous comment).
Right.
As I am sure you can handle these issues after git-import: APPROVED
Thanks a lot for the review. Please mark it as ASSIGNED, too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component