https://bugzilla.redhat.com/show_bug.cgi?id=864531
Bug ID: 864531 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: opensaml-java - Java OpenSAML library Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mgoldman@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-1/opensa... SRPM URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-1/opensa... Fedora Account System Username: goldmann Description:
OpenSAML is a set of open source C++ & Java libraries meant to support developers working with the Security Assertion Markup Language (SAML). OpenSAML 2, the current version, supports SAML 1.0, 1.1, and 2.0.
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG) Depends On| |860505, 864432
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Bug 864531 depends on bug 860505, which changed state.
Bug 860505 Summary: Review request: opensaml-java-openws - Java OpenWS library https://bugzilla.redhat.com/show_bug.cgi?id=860505
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DEFERRED
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |866410
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Spike SpikeFedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |SpikeFedora@gmail.com Assignee|nobody@fedoraproject.org |SpikeFedora@gmail.com Flags| |fedora-review?
--- Comment #1 from Spike SpikeFedora@gmail.com --- I'll do this one.
https://bugzilla.redhat.com/show_bug.cgi?id=864531
--- Comment #2 from Spike SpikeFedora@gmail.com --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [!] Rpmlint output: opensaml-java.noarch: W: file-not-utf8 /usr/share/doc/opensaml-java-2.5.3/doc/CREDITS.txt opensaml-java.src:74: W: macro-in-comment %pom_remove_dep opensaml-java.src: W: invalid-url Source0: opensaml-java-2.5.3.tar.xz opensaml-java-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados opensaml-java-javadoc.noarch: W: file-not-utf8 /usr/share/doc/opensaml-java-javadoc-2.5.3/doc/CREDITS.txt opensaml-java.spec:74: W: macro-in-comment %pom_remove_dep opensaml-java.spec: W: invalid-url Source0: opensaml-java-2.5.3.tar.xz
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: ASL 2.0 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [!] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [x] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro
=== Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on: fedora-rawhide-x86_64
=== Issues === 1. rpmlint: - Invalid source url can be ignored (scc checkout). - You could escape the comment macro (%%pom_remove_dep) or just remove it - Please fix CREDITS.txt's file encoding
https://bugzilla.redhat.com/show_bug.cgi?id=864531
--- Comment #3 from Marek Goldmann mgoldman@redhat.com --- Fixed!
Spec URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-2/opensa... SRPM URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-2/opensa...
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Spike SpikeFedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) | Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Spike SpikeFedora@gmail.com --- ================ *** APPROVED *** ================
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Marek Goldmann mgoldman@redhat.com --- Thanks for review!
New Package SCM Request ======================= Package Name: opensaml-java Short Description: Java OpenSAML library Owners: goldmann Branches: f17 f18
https://bugzilla.redhat.com/show_bug.cgi?id=864531
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Bug 864531 depends on bug 864432, which changed state.
Bug 864432 Summary: Review Request: owasp-esapi-java - OWASP Enterprise Security API https://bugzilla.redhat.com/show_bug.cgi?id=864432
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=864531
Bug 864531 depends on bug 866410, which changed state.
Bug 866410 Summary: Review Request: opensaml-java-openws - Java OpenWS library https://bugzilla.redhat.com/show_bug.cgi?id=866410
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864531
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2012-11-20 07:45:03
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864531
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- opensaml-java-2.5.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/opensaml-java-2.5.3-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864531
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864531
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- opensaml-java-2.5.3-2.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org