https://bugzilla.redhat.com/show_bug.cgi?id=2109838
Bug ID: 2109838 Summary: Review Request: golang-github-oracle-oci-sdk-60 - Go SDK for Oracle Cloud Infrastructure Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mark.e.fuller@gmx.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fuller.fedorapeople.org/golang-github-oracle-oci-sdk-60.spec SRPM URL: https://fuller.fedorapeople.org/golang-github-oracle-oci-sdk-60-60.0.0-1.fc3... Description: Go SDK for Oracle Cloud Infrastructure Fedora Account System Username: fuller
https://bugzilla.redhat.com/show_bug.cgi?id=2109838
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review? | |needinfo?(mark.e.fuller@gmx | |.de) Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Update to 65.45.0
- Update to SPDX licensing. Also it is dual licensed with UPL
- Don't disable the entire check section
- don't leave this if you are not packaging the library :
%files %license LICENSE.txt NOTICE.txt %doc example CHANGELOG.md CONTRIBUTING.md README.md THIRD_PARTY_LICENSES.txt %doc THIRD_PARTY_LICENSES_DEV.txt
- use latest go2rpm for you spec:
# Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil}
# https://github.com/oracle/oci-go-sdk %global goipath github.com/oracle/oci-go-sdk/v65 Version: 65.45.0
%gometa -f
%global common_description %{expand: Go SDK for Oracle Cloud Infrastructure.}
%global golicenses LICENSE.txt NOTICE.txt %global godocs example CHANGELOG.md CONTRIBUTING.md README.md\\ SECURITY.md
Name: %{goname} Release: %autorelease Summary: Go SDK for Oracle Cloud Infrastructure
License: Apache-2.0 OR UPL-1.0 URL: %{gourl} Source: %{gosource}
%description %{common_description}
%gopkg
%prep %goprep %autopatch -p1
%generate_buildrequires %go_generate_buildrequires
%install %gopkginstall %if %{with check} %check for test in "TestUploadFileMultiparts" \ "TestUploadStreamMultiparts" \ "TestUploadReqest_initDefaultValues" \ "TestUploadFileReqest_initDefaultValues" \ "TestUploadManager_UploadFile" \ "TestUploadManager_UploadStream" \ ; do awk -i inplace '/^func.*'"$test"'(/ { print; print "\tt.Skip("disabled failing test")"; next}1' $(grep -rl $test) done %gocheck %endif
%gopkgfiles
%changelog %autochangelog
Needinfo when you have fixed the issues.
Product: Fedora Version: rawhide Component: Package Review
Red Hat Bugzilla bugzilla@redhat.com has canceled Package Review package-review@lists.fedoraproject.org's request for Mark E. Fuller mark.e.fuller@gmx.de's needinfo: Bug 2109838: Review Request: golang-github-oracle-oci-sdk-60 - Go SDK for Oracle Cloud Infrastructure https://bugzilla.redhat.com/show_bug.cgi?id=2109838
--- Comment #4 from Red Hat Bugzilla bugzilla@redhat.com --- The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days
package-review@lists.fedoraproject.org