https://bugzilla.redhat.com/show_bug.cgi?id=1315021
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Dmitry Mikhirev from comment #10)
> Please always link to the raw spec file for fedora-review's
sake.
I'm sorry.
Not a big problem, just an additional step.
> No %check (apart from the desktop files and appdata) :(
I did not add running tests because they require X server connection. I
supposed that there should be a workaround, but I found the page
https://fedoraproject.org/wiki/PackageMaintainers/GraphicalTests only after
submitting this review request. So I can try to enable tests now.
I think it's
useful. At least checking if the binaries actually run
can be useful:
$ /usr/bin/openvibe-external-application-launcher
/usr/bin/openvibe-external-application-launcher: line 24: /usr/bin/: Is a
directory
It seems that something is wrong here.
> Installation fails with:
> nothing provides libquat.so.07()(64bit) needed by openvibe-1.1.0-1.fc25.x86_64.
Right, it is provided by vrpn package.
Oh, OK. I didn't notice that. With vrpn
installed everything installs fine.
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component