Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Bug ID: 890417 Summary: Review Request: php-Analog - PHP micro logging package Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: johan@x-tnd.be
Spec URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog-1.0.0.1-1.git876d8a3bb... Description: MicroPHP logging package based on the idea of using closures for configurability and extensibility. It functions as a static class, but you can completely control the writing of log messages through a closure function (aka anonymous functions). Fedora Account System Username: trasher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 670366 --> https://bugzilla.redhat.com/attachment.cgi?id=670366&action=edit phpci.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 670367 --> https://bugzilla.redhat.com/attachment.cgi?id=670367&action=edit php-Analog-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 890417
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #3 from Remi Collet fedora@famillecollet.com --- [!]: Requires correct, justified where necessary. [!]: Package installs properly. Note: Installation errors (see attachment) php-mongo => php-pecl(mongo)
I will prefer to not require this optional dependency (pull a lot of stuff) Proposal: remove the requires, and add a comment in package description or create a php-Analog-mongo sub-package (seems a bit ugly for a single file)
[!]: Package complies to the Packaging Guidelines I don't understand version, why 1.0.0.1 ? If post release, should be 1.0.0-1.gitxxx If pre release , should be 1.0.0.1-0.1.gitxxx or justify/explain
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
From https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li... "Common licenses that require including their texts with all derivative works include ASL 2.0, EPL, BSD and MIT."
So open a upstream request and: wait for upstream new release or add the LICENSE to the package sources
[!]: %check is present and all tests pass.
%check phpunit tests
[!]: Rpmlint is run on all installed packages. php-Analog.src: E: specfile-error error: Macro % has illegal name (%define)
-%global %reldate 20121224 +%global reldate 20121224
or drop this unused macro.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #4 from Johan Cwiklinski johan@x-tnd.be --- I agree with you for the pecl-mongo requirement, I'll drop it and write a line about it. I'll also drop unused reldate macro.
The version... Well, I guess I should not package anything after the few days following Xmas day :D
I've reported license issue upstream: https://github.com/jbroadway/analog/issues/2
Thank you Remi to take that review :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #5 from Johan Cwiklinski johan@x-tnd.be --- New version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog-1.0.0-1.git876d8a3bb.f...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #6 from Remi Collet fedora@famillecollet.com --- * version (1.0.0) => fixed * requires (mongo) => fixed * License (upstream request + file) => fixed
- Mongo - Save to MongoDB collection, requires php-pecl(mongo) package to be installed)
=> typo, remove trailing )
[!]: %check is present and all tests pass.
%check phpunit tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #7 from Johan Cwiklinski johan@x-tnd.be --- Ooops, typo fixed and %check added :)
I had an issue running tests, fix that has been included in specfile has been submitted upstream: https://github.com/jbroadway/analog/issues/3
Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Analog/php-Analog-1.0.0-2.git876d8a3bb.f...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #8 from Remi Collet fedora@famillecollet.com --- * typo => fixed * %check => fixed
All seems fine, no blocker.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4827045
=== APPROVED ===
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #9 from Johan Cwiklinski johan@x-tnd.be --- Thank you for the review :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Johan Cwiklinski johan@x-tnd.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Johan Cwiklinski johan@x-tnd.be --- New Package SCM Request ======================= Package Name: php-Analog Short Description: PHP micro logging package Owners: trasher Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #11 from Kevin Fenzi kevin@scrye.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Analog-1.0.0-2.git876d8a3bb.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Analog-1.0.0-2.git876d8a3bb.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Analog-1.0.0-2.git876d8a3bb.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-11 18:49:00
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-Analog-1.0.0-2.git876d8a3bb.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org